search

ElektraInitiative / go-elektra-archive

Go bindings for Elektra
https://libelektra.org
BSD 3-Clause "New" or "Revised" License
5 stars 4 forks source link

code review #2

Closed markus2330 closed 4 years ago

markus2330 commented 4 years ago

code review: you can comment using this PR

raphi011 commented 4 years ago

@markus2330 This PR was closed automatically by mistake - Could you still take a look at the comments?

markus2330 commented 4 years ago

Yes, I will look at it but I cannot do it right now.

raphi011 commented 4 years ago

@markus2330 the next review round can commence :)

raphi011 commented 4 years ago

@markus2330 Did you re-review already? Not sure because you added a comment but there are still some open comments.

markus2330 commented 4 years ago

I now also pushed ba59313ac0800221a8ebc3c898f585588a7df19b here.

markus2330 commented 4 years ago

It is not a rereview but a leftover from the last review.

How should I do the review the next time?

raphi011 commented 4 years ago

Not sure because I'm developing in the master branch which makes PR's and reviews harder to do. I'd say we finish this 'PR' as soon as possible fix any remaining problems that may come up with branches and PR's.

raphi011 commented 4 years ago

Added another commit - still need feedback on this comment.

markus2330 commented 4 years ago

Not sure because I'm developing in the master branch which makes PR's and reviews harder to do.

Maybe you can change this for this one review? (With force push you can also change this now)