search

ElektraInitiative / lcdproc

Client/server suite for controlling a wide variety of LCD devices
http://lcdproc.org/
GNU General Public License v2.0
2 stars 1 forks source link

Elektra tutorial #5

Closed ghost closed 5 years ago

ghost commented 5 years ago

This PR is a result of #2332.

The documentation deals with

since qt-gui, web and kdb editor do not work correctly as of now to be included in the tutorial. Please feel free to comment on the README.

I also changed the specification to the array form for enums as requested by @kodebach .

ghost commented 5 years ago

Thank you very much for the review @kodebach. Unfortunately I came to serious errors after switching to the array notation which forced me to exclude the kdb editor part

ghost commented 5 years ago

@markus2330 I am not sure if you regularly look here for the label "ready to merge" (which I just created) so I mention you for safety reasons.

markus2330 commented 5 years ago

Two more general remarks:

  1. I like the tutorial, it would be good if we can also have it within the Elektra repo.
  2. I think we can improve the overall framing: People might not care so much about validation but they care about usability. So we should put the usability as main argument. Usability also includes error messages.
ghost commented 5 years ago

@markus2330 I incorporated your desired changes. Please review again

markus2330 commented 5 years ago

@kodebach is the PR ok for you now?

@Piankero please also create a PR with this tutorial for the Elektra repo.

ghost commented 5 years ago

@markus2330 & @kodebach : I finished testing all clients. I needed to fix minor things here and there but if https://github.com/ElektraInitiative/libelektra/pull/2504 is merged, it should be fine. I also excluded all boolean types and moved them to string. If it is clear how the boolean plugin will work I will leave it commented out. I also incorporated https://github.com/ElektraInitiative/lcdproc/issues/6 as default in commit aef4a8f which works fine. Please take a last review over my last few commits so we can finish this PR finally :)

kodebach commented 5 years ago

Sorry, for the delay... I thought I approved this already