search

ElektraInitiative / libelektra

Elektra serves as a universal and secure framework to access configuration settings in a global, hierarchical key database.
https://www.libelektra.org
BSD 3-Clause "New" or "Revised" License
208 stars 123 forks source link

[FLOSS] augeas plugin fails silently on meta-set #4584

Closed Bujuhu closed 11 months ago

Bujuhu commented 1 year ago

As discussed in #4555

Steps to Reproduce the Problem

$ sudo kdb mount /etc/hosts system:/tests/hosts augeas lens=Hosts.lns
# RET: 0
$ sudo kdb meta-set system:/tests/hosts somevalue a
# RET: 0  
$ sudo kdb meta-get system:/tests/hosts somevalue
Metakey not found
# RET: 2

Expected Result

Should print an error on sudo kdb meta-set system:/tests/hosts somevalue a and return a non 0 exit code

Actual Result

$ sudo kdb meta-set system:/tests/hosts somevalue a fails silently and sudo kdb meta-get system:/tests/hosts somevalue returns Metakey not found

System Information

Operating System: Arch Linux, Kernel 5.19.13-arch1-1

kdb and plugins version

# kdb --version
KDB_VERSION: 0.9.11
SO_VERSION: 5

Relevant Source Code

augeas does not check if unused meta keys exist and ignores them

https://github.com/ElektraInitiative/libelektra/blob/cf4b6f303432dbfdcb9cc222c84f41045962b211/src/plugins/augeas/augeas.c#L590

github-actions[bot] commented 11 months ago

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

github-actions[bot] commented 11 months ago

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart: