ElektraInitiative / libelektra

Elektra serves as a universal and secure framework to access configuration settings in a global, hierarchical key database.
https://www.libelektra.org
BSD 3-Clause "New" or "Revised" License
208 stars 123 forks source link

Fix macOs Actions #4976

Closed 4ydan closed 1 year ago

4ydan commented 1 year ago

4973

Basics

Checklist

Review

Labels

atmaxinger commented 1 year ago

Have you tried brew install libassuan@2.5.5 and brew pin libassuan@2.5.5 ?

4ydan commented 1 year ago

Have you tried brew install libassuan@2.5.5 and brew pin libassuan@2.5.5 ?

Brew install didnt work because a higher version is installed, brew pin I didnt try.

atmaxinger commented 1 year ago

Well, it wouldn't work either way, just tried it. Seems like this solution here is the only way to do it.

4ydan commented 1 year ago

Yea, the best would be probably to port libelektra to 2.5.6 and avoid dark magic in the yml file.

atmaxinger commented 1 year ago

Does libelektra actually directly depend upon libassuan? Or is this a transitive dependency?

markus2330 commented 1 year ago

It is only a development dependency, for ASAN builds. I don't think anyone would use it for production builds.

4ydan commented 1 year ago

Will try some stuff on the macos github actions on my fork, will close this to not start the other pipelines.

4ydan commented 1 year ago

These tests behave very weird, I removed all my changes, and the macos/cirrus tests pass now. I doubt that its just because of macos12 or brew cleanup. Also the jenkins pipeline fails randomly for no reason :s

atmaxinger commented 1 year ago

jenkins build libelektra please

atmaxinger commented 1 year ago

It seems like time itself fixed this issue. So there's probably been a package update in homebrew, this PR is no longer needed. Thanks for working on it anyways!

4ydan commented 1 year ago

Nice!