ElektraInitiative / libelektra

Elektra serves as a universal and secure framework to access configuration settings in a global, hierarchical key database.
https://www.libelektra.org
BSD 3-Clause "New" or "Revised" License
208 stars 123 forks source link

bindings/rust: update bindgen version #4991

Closed horenso closed 2 months ago

horenso commented 1 year ago

Update bindgen for rust bindings to 0.66.1 #4989.

bindgen changed some defaults regarding the equality of usize and size_t. They added the option .size_t_is_usize(true) but made it default true in a later version. When bumping the bindgen version the error goes away. Read more about this in this issue and also here.

Basics

Checklist

Review

Labels

coveralls commented 1 year ago

Coverage Status

coverage: 99.913% (-0.001%) from 99.914% when pulling bde799dbe2c130cd9d941b596934f4c6acecb418 on fix-rust-binding into dbbe4ae4f669c322a8f95f59112d3f5fc370bbd9 on master.

markus2330 commented 1 year ago

Thx, worked for me, I published the 0.11.1 packages.

Let us see if this now fixed the overall problem, afaik the initial problem was that libmodbus needed bindgen 0.55.1 and somehow @fel115 had troubles using it together with the different version of bindgen Elektra was using.

I created https://github.com/ElektraInitiative/opensesame/issues/67

fel115 commented 1 year ago

Thx, worked for me, I published the 0.11.1 packages.

Let us see if this now fixed the overall problem, afaik the initial problem was that libmodbus needed bindgen 0.55.1 and somehow @fel115 had troubles using it together with the different version of bindgen Elektra was using.

With the new release everything is working now :+1:

horenso commented 1 year ago

Is it expected that the macOS builds don't work or how can I fix them? Should we close this issue when https://github.com/ElektraInitiative/opensesame/issues/67 is done?

markus2330 commented 1 year ago

Only the Jenkins job is non-optional. The error there seems to be a spurious problem. It can be retriggered with commenting jenkins build libelektra please.

@atmaxinger will you review and merge?

markus2330 commented 1 year ago

jenkins build libelektra please

github-actions[bot] commented 3 months ago

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new PR with the remainder of this PR. Thank you for your contributions :sparkling_heart:

github-actions[bot] commented 2 months ago

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new PR with the remainder of this PR. Thank you for your contributions :sparkling_heart: