search

ElektraInitiative / opensesame

3 stars 5 forks source link

Implementation of MOD-BME280 #58

Closed fel115 closed 9 months ago

fel115 commented 1 year ago

The aim of these issues is to exchange the MOD-ENV module with MOD-BME280. The difference between these two modules is, that the MOD-ENV is also able to measure the air quality.

fel115 commented 1 year ago

@markus2330, based on my understanding, it seems that we need to modify the 'environment.rs' file to enable configuration specifically for using theMOD- BME280. This adjustment is necessary because the MOD-ENV includes both the BME280 and an additional CO2 sensor.

fel115 commented 1 year ago

@markus2330 what's the difference between "environment.rs" and "sensors.rs"? What sensors are connected over the '/dev/ttyACM0'? Is there external hardware with sensors connected which are sending the sensor data over this serial connection?

Would it be better to create a handler in which it is possible to enable env-sensors and the other sensors explicitly?

markus2330 commented 1 year ago

based on my understanding, it seems that we need to modify the 'environment.rs' file to enable configuration specifically for using theMOD- BME280

Using environment for BME280-only does not make much sense.

Probably easiest is if you keep environment.rs as it is, because I still use these sensors. A module using only bme280::i2c::BME280 should be quite trivial, needing nearly nothing from environment.rs. But if you carefully split Environment in two modules, it is fine, too. (It is okay for me to reconfigure the current modules that use environment).

what's the difference between "environment.rs" and "sensors.rs"?

They have basically nothing to do with each other. environment is MOD-ENV, Sensors is Arduino with air sensors.

What sensors are connected over the '/dev/ttyACM0'? Is there external hardware with sensors connected which are sending the sensor data over this serial connection?

Exactly, Ardruino with up to 12 MQ135

Would it be better to create a handler in which it is possible to enable env-sensors and the other sensors explicitly?

Yes, the main loops should get removed, so environment is not hacked into the sensors loop etc.

fel115 commented 1 year ago

OK, then I would create a new Module for MOD-BME and the MOD-IR-TEMP for returning temperature, pressure, and humidity. So the new module can be used in the main loop if it is configured.