search

Elektrobit / flake-pilot

Registration/Control utility for applications launched through a runtime-engine, e.g containers
MIT License
9 stars 5 forks source link

Replace yaml-rust with serde_yaml #128

Closed Ichmed closed 1 year ago

Ichmed commented 1 year ago

Right now the config in both pilots is being parsed into a generic Yaml node that is evaluated on the fly. This may cause destructive actions to be performed before terminating the program due to a faulty config.

By parsing deserializing the config into a fixed struct the pilot can quit on startup if the config is invalid. This will also prevent errors due to typos and make the config more discoverable for new contributors.

schaefi commented 1 year ago

Yeah you are completely right here. I moved other parts of the project e.g flake-ctl to serde_yaml but not yet in all components. There is potential to break the yaml by treating it "raw" and I agree moving to serde_yaml is the way to go in all parts of the code

schaefi commented 1 year ago

We are complete here imho. Thanks much for the effort