Closed isbm closed 1 year ago
This is not due to the changes done here, but cargo build
ignores profiles not defined in the top level cargo file
Since the release profiles are identical anyway the individual ones should be removed and replaced with one in the top Cargo.toml
I'm seconding removing the upx step since, afaik, it does not change binary size during runtime but only on disk.
Startup time is much more valuable then disk space (especially because many flakes may be starting at once while there will be only on pilot binary on disk)
LGTM
If there is no any particular reasons why we should not remove symbols information, then this should be activated back. However I do see the reason not to UPX-compress the release binaries by default, because it does not do any impact on memory-allocated size, however, it burns CPU to unpack the binary every launch, while disk is cheap. Some systems detect UPX compressed binaries as a virus, which only adds to the problem.
Whoever still needs UPX can use
make compress
as an extra step.