Elem8100 / MapleStory-GM-Client

Offline MapleStory Client Emulator
Mozilla Public License 2.0
352 stars 95 forks source link

v3.32 Feedback #11

Closed Sunaries closed 4 years ago

Sunaries commented 4 years ago

@Elem8100 Thank you for the new release. I really like the recent documents feature where you can load the most used folders! πŸ‘ With every release, I will try my best to find bugs and give you feedback in separate Issues.

1. UI / Mini Map is still not functional. 2. I believe you've made the font size smaller, but I think it can go down one size. See the comparison:

β–² GMS v213

β–² MapleStoryGM v3.32

3a. Label ring for pets does not match each individual pet. Taotie's label ring is pink while it should be red. This applies to all pets. 3b. This issue also applies to Androids. 4. Any way to equip pet accessories that will change their appearance? 5. Height between Char ID and Medal is too big. It should be smaller so that it does not

β–² GMS v213

β–² MapleStoryGM v3.32

6. Familiar tab is not working. GMS received Familiar revamp. Is that the problem? 7. Chairs are not 100% working with your own character. If you change your character's appearance and load to a new map and go on a chair, it will report an error 'Item not found'. I cannot close the program, but I have to kill the process through Task Explorer. I recorded this bug, please see the video below the images.

Video: https://streamable.com/t7o6f4

8a. Every time you start MapleStoryGM, there is a preset character. Is there a way to make it that you can create your own character with your own label ring and Char ID? 8b. Is there also a way to remove label ring and use default name tag?

8c. This also applies to Char ID, settings in Display etc. Everytime you relaunch the program, you will need to enter a name, tick the boxes such as Portal Info etc. It would be nice that your program remembers these settings. 9. Improving the search feature by not being so strict when it comes to apostrophes in search box.

β–² The item appears when the apostrophe was added.

β–² No item appears when omitting the apostrophe. It would be better to search this way with the item appearing even though there's no apostrophe.

10. Search: If you scroll all the way down to the list to reach the last ID and you go over it, it'll jump back to the very first ID. It should stop at the last ID and not jump back on the first of the list.

11. Dropping mob 8645048 gives an access violation error.

12. There is no search option in the Cash Effect tab.

13. Using label ring through Avatar tab gives you access violation error that can be ignored later on. Maybe resolve this by either ignoring and not granting an error or allowing it to use the label ring effect.

Elem8100 commented 4 years ago

v3.3 and Win10 worked fine.You should check your OS.

snap

Sunaries commented 4 years ago

As of v3.32 the UI does not appear. My system is running on a legitimate OS: Windows 10 Pro 64-bit (10.0, build 18363) πŸ˜•

Elem8100 commented 4 years ago

Windows 10 Pro 64-bit build 18363 still worked fine. No way to fix the issue or bug that you encountered

Sunaries commented 4 years ago

Very strange that it works for you and not for me. I am running the OS on Korean locale, but I doubt that is the issue.

Update: I launched the program on my laptop. It does not show the UI on that computer. My laptop has Windows 10 Home 64-bit build 18363. On my laptop I am running it on default locale.

Elem8100 commented 4 years ago

You must try v3.3 or v3.31 MapleStoryGM_Test, Because in v3.32 i comment out(delete) UI code. Please try again.

Sunaries commented 4 years ago

You must try v3.3 or v3.31 MapleStoryGM_Test, Because in v3.32 i comment out(delete) UI code. Please try again.

Tested the following just now again on my own PC and on my laptop:

Elem8100 commented 4 years ago

You must try v3.3 or v3.31 MapleStoryGM_Test, Because in v3.32 i comment out(delete) UI code. Please try again.

Tested the following just now again on my own PC and on my laptop:

* v3.31 MapleStoryGM works, but not the UI.

* v3.31 MapleStoryGM_Test gives me an **access violation error** when opening any map. I've reported this before.

* v3.3 MapleStory gives me an **access violation error** when opening any map. I've reported this before.

That's really weird. Over 100 users tested but no one report that issue.

Sunaries commented 4 years ago

You must try v3.3 or v3.31 MapleStoryGM_Test, Because in v3.32 i comment out(delete) UI code. Please try again.

Tested the following just now again on my own PC and on my laptop:

* v3.31 MapleStoryGM works, but not the UI.

* v3.31 MapleStoryGM_Test gives me an **access violation error** when opening any map. I've reported this before.

* v3.3 MapleStory gives me an **access violation error** when opening any map. I've reported this before.

That's really weird. Over 100 users tested but no one report that issue.

It is indeed really weird. I will ask others and see if they encounter this issue.

Sunaries commented 4 years ago

I have asked a friend of mine. He downloaded the version 3.3 and tried to open random maps. He did not get an error, but the maps did not load for him even though the BGM plays. He is on Windows 10.

He tried this with the latest GMS and KMS client. It seems I am not the only one encountering issues.

PirateIzzy commented 4 years ago

I also tried with all the UI settings. I was able to get the basic map to load, but with all these options selected: image

I only see the following, without any Character UI settings: image

My OS specs: image

Elem8100 commented 4 years ago

You must try v3.3 v3.32 has no UI.

Sunaries commented 4 years ago

Yeah, v3.3 worked for him with enabling UI. He showed me it. It’s very strange that the 3.3 version is giving me an access violation error. I don’t know how to get rid of it... The latest version works fine.

Sunaries commented 4 years ago

v3.33

Elem8100 commented 4 years ago

7. Chairs are not 100% working with your own character.....

  1. Using label ring through Avatar tab gives you access violation error...

I have tried many times but still couldn't reproduce the issue.

Elem8100 commented 4 years ago

v3.33

MSEA v196: TotemEffect gives me an access violation error. This does not happen in GMS client.

MSEA has no Totem, see Character.wz

Sunaries commented 4 years ago

7. Chairs are not 100% working with your own character.....

  1. Using label ring through Avatar tab gives you access violation error...

I have tried many times but still couldn't reproduce the issue.

That is weird because I can and I'm using the latest version (v3.33).

Issue 13. See: https://streamable.com/apx5dr

MSEA v196: TotemEffect gives me an access violation error. This does not happen in GMS client. MSEA has no Totem, see Character.wz

Ah, problem solved. Maybe add a warning to users trying to open it saying that the file cannot be found in the data?

Elem8100 commented 4 years ago

Issue 13. See: https://streamable.com/apx5dr

Avatar form only for display/edit Equip it can't show label ring effect. Label ring does not belong to visual Equip. This way is nonsense since there is label ring Tab and come with search box. Looks like something is mess-up. I'll remove label ring from equip search list.

Sunaries commented 4 years ago

Latest KMST update introduces a new PNG format. See: https://github.com/Kagamia/WzComparerR2/commit/0c720d27dbd3e1daaafc214691a3be38370cf83b

Currently, when you are trying to summon the new NPC in a map, you'll get an error.

Elem8100 commented 4 years ago

Thanks for the report, I'll check it later. But now the biggest problem is the UI display. I've divided them into several parts. Help me test that and see what happen.

Sunaries commented 4 years ago

Thanks for the report, I'll check it later. But now the biggest problem is the UI display. I've divided them into several parts. Help me test that and see what happen.

I have downloaded the ZIP file and ran some tests.

Chat works.

MainBar doesn't work. It gives me an error when opening a random map.

MiniMap works. However, the font should be tweaked. Several buttons on minimap UI are missing such as: -, +, ㅁ, World and NPC.

↑ MapleStoryGM

↑ GMS

Form works and gives me the following to see:

I can close the window by ticking the "UI" box in Display. (Shouldn't it be the other way around? Untick to remove and tick to show?)

Form2 works, but I don't know what it does. I only see the following:

Elem8100 commented 4 years ago

Ok, Now we have the direction how to fix.

Elem8100 commented 4 years ago

Let's next test. UI_Test2.zip

Sunaries commented 4 years ago

Let's next test. UI_Test2.zip

ExpBar doesn't work. Error.

MainBar now works. I see the following when opening a map.

The buttons open their respective windows. The player ID name is not centered. You cannot expand the item inventory.

StatusBar works.

Is Lv 255 default? Can you change it?

Elem8100 commented 4 years ago

Next test. The bug is almost resolve,I think! UI_test3.0.zip UI_test3.1.zip UI-test3.2.zip

Sunaries commented 4 years ago

Next test. The bug is almost resolve,I think! UI_test3.0.zip UI_test3.1.zip UI-test3.2.zip

I've added all parts in the previous folder of UI_Test2. Results:

Part1: Works.

part1

Part2: Works. I see what I saw when I opened Part 1. Part3: Doesn't work.

part3

Part4: Doesn't work.

part4

Part5: Works. I see what I saw when I opened Part 1. Part6: Doesn't work.

part6

emblem

Elem8100 commented 4 years ago

Next test. UI_Test4.1.zip UI_Test4.2.zip UI_Test4.0.zip

Sunaries commented 4 years ago

Next test. UI_Test4.1.zip UI_Test4.2.zip UI_Test4.0.zip

Results:

raw doesn't work.

utf doesn't work.

ansi doesn't work.

unicode doesn't work.

wide doesn't work.

string doesn't work.

Elem8100 commented 4 years ago

Test again. UI_Test.zip

Sunaries commented 4 years ago

Test again. UI_Test.zip

Results:

Project1 works. A window appears and when I click on "Button1", the following appears:

MapleStoryGM works. I can open maps and the UI is available for me. Changing the Char ID now changes the username in the UI in the bottom area.

Elem8100 commented 4 years ago

Thanks for the test. It should be 99.54 but why become 99,54 in your OS . That's let me crazy. Anyway,the problem is absolutely solved. snap

Sunaries commented 4 years ago

Thanks for the test. It should be 99.54 but why become 99,54 in your OS. That's let me crazy. Anyway,the problem is absolutely solved.

Probably because my PC is set to my country's locale ( I live in the Netherlands, Europe). In my country we use the decimal comma. Good to hear it is solved. πŸ‘ Once you release a new version, I will create a new Issue to check for bugs and recommended changes.