search

ElemeFE / element-react

Element UI
https://elemefe.github.io/element-react/index
MIT License
2.83k stars 443 forks source link

Dialog: close modal by pressing ESC don't work #993

Open ubaidisaev opened 5 years ago

ubaidisaev commented 5 years ago

Description

Can't close Dialog modal by pressing ESC button

Reproduce Steps

  1. Open Dialog https://elemefe.github.io/element-react/index#/en-US/dialog
  2. Try to close it by pressing ESC button

Solution

It seems like the Refs to that element is not part of the DOM yet when we call componentDidUpdate method. Adding tabIndex attribute and some delay before setting focus to that modal solve this problem.

dialog