ElemeFE / element

A Vue.js 2.0 UI Toolkit for Web
https://element.eleme.io/
MIT License
54.13k stars 14.64k forks source link

[Bug Report] collapse 折叠面板手风琴模式下 name = 0 时无法关闭 #3544

Closed leezng closed 7 years ago

leezng commented 7 years ago

[Bug Report] collapse 折叠面板手风琴模式下 name = 0 时无法关闭

使用 name 属性定义唯一标识,当 name = 0 时,该折叠面板无法关闭,可见 JSFiddle URL

ElementUI version

1.2.4

OS/Browsers version

Windows7 / Chrome 55

Vue version

2.1.10

下面截取 collapse.vue 的代码,感觉是判断 this.activeNames[0] && ... 时由于是 0 直接 return false

methods: {
  setActiveNames(activeNames) {
    activeNames = [].concat(activeNames);
    let value = this.accordion ? activeNames[0] : activeNames;
    this.activeNames = activeNames;
    this.$emit('input', value);
    this.$emit('change', value);
  },
  handleItemClick(item) {
    if (this.accordion) {
      this.setActiveNames(
        this.activeNames[0] &&
        this.activeNames[0] === item.name
        ? '' : item.name
      );
    }
  }
}
Leopoldthecoder commented 7 years ago

Fixed in #3546

reverland commented 7 years ago

其实我想吐槽为啥想不开用0来做name……