search

Element-34 / php-webdriver

thin php client for webdriver.
122 stars 55 forks source link

changes from https://code.google.com/p/selenium/source/detail?r=8c3c6577... #44

Closed voodoo144 closed 11 years ago

voodoo144 commented 11 years ago

Now POST to /session doesn't redirect to /session/:sessionId url, it now return sessionId value in json response.

voodoo144 commented 11 years ago

@@ -56,8 +56,8 @@ public function session($browser = 'firefox', '/session', array('desiredCapabilities' => $desired_capabilities), $curl_opts);

  • // var_dump($results);
  • return new PHPWebDriver_WebDriverSession($results['info']['url']);
  • //var_dump($results);
  • return new PHPWebDriver_WebDriverSession($results['info']['url'].$results['sessionId']);

I test this code with GhostDriver 1.0.4, when I write it Selenium 2.34 was still unreleased.

jvanbouchaute commented 11 years ago

+1. Breaks compatibility with Selenium 2.35

adamgoucher commented 11 years ago

I'll look at this tonight

jvanbouchaute commented 11 years ago

Thanks ! Op 20-aug.-2013 12:29 schreef "adam goucher" notifications@github.com het volgende:

I'll look at this tonight

— Reply to this email directly or view it on GitHubhttps://github.com/Element-34/php-webdriver/pull/44#issuecomment-22935523 .

voodoo144 commented 11 years ago

thanks a lot )