Element-Research / rnn

Recurrent Neural Network library for Torch7's nn
BSD 3-Clause "New" or "Revised" License
941 stars 313 forks source link

Implementation Request : On Multiplicative Integration with Recurrent Neural Networks #306

Closed Kaixhin closed 6 years ago

Kaixhin commented 8 years ago

On Multiplicative Integration with Recurrent Neural Networks shows a boost in performance with RNNs by replacing the (elementwise) addition of the input and previous hidden state with an elementwise multiplication (a.k.a. the Hadamard product).

Rather than introducing a MI-RNN, MI-LSTM, MI-GRU etc., adding an extra flag to each of the existing units would seem better for code-reuse?

nicholas-leonard commented 8 years ago

Rather than introducing a MI-RNN, MI-LSTM, MI-GRU etc., adding an extra flag to each of the existing units would seem better for code-reuse?

@Kaixhin Yes. Those are some really promising results. Do you plan on implementing MI for any of the rnn modules?

Kaixhin commented 8 years ago

@nicholas-leonard No - I think this is best left to someone who's already familiar with the codebase (as opposed to a pure user, e.g. myself).

nicholas-leonard commented 8 years ago

@Kaixhin Sounds good. In any case, thanks for suggesting the addition. I believe @Manojelement wants to work on it.

ahmedmagdiosman commented 7 years ago

Hey guys, is there any update on this?