Could you please add sizeAverage in SequencerCriterion.lua?

Element-Research / rnn

Recurrent Neural Network library for Torch7's nn

BSD 3-Clause "New" or "Revised" License

939 stars 313 forks source link

Could you please add sizeAverage in SequencerCriterion.lua? #341

Open hfxunlp opened 7 years ago

hfxunlp commented 7 years ago

It makes sense that average the sequence criterion, otherwise it tends to get larger criterion with longer sequences.

nicholas-leonard commented 7 years ago

@anoidgit You seem to need this most. Could you send a pull request (PR) with your suggested changes? We require three things to merge a PR: code, unit test, documentation. You can look at closed PRs for examples. I don't have much time to code right now as I am travelling through Europe. I can try to find the time to help you, but I have no time to do it.

hfxunlp commented 7 years ago

@nicholas-leonard OK, I'm trying my best to do it.