[Feature request] nn.seqBRNN ability to stack and maskZero()

Element-Research / rnn

Recurrent Neural Network library for Torch7's nn

BSD 3-Clause "New" or "Revised" License

941 stars 313 forks source link

[Feature request] nn.seqBRNN ability to stack and maskZero() #421

Open jpilaul opened 7 years ago

jpilaul commented 7 years ago

I am currently doing something like this: brnn = nn.seqBRNN(vec_size,rnn_size) brnn.forwardModule:maskZero() brnn.backwardModule:maskZero() I have extended seqBRNN to add the ability stack seqBRNN with a stack_size argument that adds modules in a loop. I also added a seqBRNN:maskZero() method on my local repo.

If this is something that you might want, should I send a merge request?

Thanks