Element84 / filmdrop-ui

A web UI to search and display results from the FilmDrop STAC API.
Other
23 stars 1 forks source link

Ba/feature/add cart button #223

Closed bradleyandrick closed 1 year ago

bradleyandrick commented 1 year ago

Related Issue(s):

Proposed Changes:

  1. Add cart button to search bar if config set to true
  2. Add base of cart modal component

BONUS 1: fixed legend style bug - it now does not float high if no publish/launch/analyze buttons are present

BOUNS 2: refactor of responsiveness for mid and small size screens (first pass to resolve glaring issues, better refactor recommended for future ticket)

Before BOUNS 2:

After BOUNS 2:

To test:

all tests pass 🍏 npm run test

Tests for Cart Button

Tests for Bonus 1

PR Checklist:

bradleyandrick commented 1 year ago

RE: changelog note:

Added

  • Cart button added to search bar if CART_ENABLED set to true in config.json (WIP feature)

it's already in readme. I updated this note to be more clear

stephenkilbourn commented 1 year ago

this looks good, but a suggestion on line 294 of src/components/Search/Search.css to make that flex-direction: row for mobile.

@media screen and (max-width: 975px) {

  .secondSearchItemsGroup {
    width: 100%;
    flex-direction: row;
  }

keeping the column feels like a lot of extra space vs this:

ui-row
bradleyandrick commented 1 year ago

this looks good, but a suggestion on line 294 of src/components/Search/Search.css to make that flex-direction: row for mobile.

@media screen and (max-width: 975px) {

  .secondSearchItemsGroup {
    width: 100%;
    flex-direction: row;
  }

keeping the column feels like a lot of extra space vs this: ui-row

updated to change to flex-direction: row between 975 down to 600 then added another tag to go back to flex-direction: column below that