Closed bradleyandrick closed 1 year ago
RE: changelog note:
Added
- Cart button added to search bar if
CART_ENABLED
set to true inconfig.json
(WIP feature)
it's already in readme. I updated this note to be more clear
this looks good, but a suggestion on line 294 of src/components/Search/Search.css
to make that flex-direction: row
for mobile.
@media screen and (max-width: 975px) {
.secondSearchItemsGroup {
width: 100%;
flex-direction: row;
}
keeping the column feels like a lot of extra space vs this:
this looks good, but a suggestion on line 294 of
src/components/Search/Search.css
to make thatflex-direction: row
for mobile.@media screen and (max-width: 975px) { .secondSearchItemsGroup { width: 100%; flex-direction: row; }
keeping the column feels like a lot of extra space vs this:
updated to change to flex-direction: row
between 975 down to 600 then added another tag to go back to flex-direction: column
below that
Related Issue(s):
Proposed Changes:
BONUS 1: fixed legend style bug - it now does not float high if no publish/launch/analyze buttons are present
BOUNS 2: refactor of responsiveness for mid and small size screens (first pass to resolve glaring issues, better refactor recommended for future ticket)
Before BOUNS 2:
After BOUNS 2:
To test:
all tests pass 🍏
npm run test
Tests for Cart Button
CART_ENABLED
tofalse
inconfig.json
CART_ENABLED
totrue
inconfig.json
mainSlice.js
in editor (src/redux/slices/mainSlice.js)cartItems: []
on line 36 to becartItems: [{id: 'test'}]
to manually mock items in cartTests for Bonus 1
SHOW_PUBLISH_BTN
is true inconfig.json
AND/ORANALYZE_BTN_URL
AND/ORLAUNCH_URL
setSHOW_PUBLISH_BTN
to false inconfig.json
ANALYZE_BTN_URL
ANDLAUNCH_URL
inconfig.json
PR Checklist: