Closed bradleyandrick closed 1 year ago
Related Issue(s):
Proposed Changes:
configHelper.js
DoesFaviconExistService
get-config-service
BOUNS: Add favicon config setting to allow custom favicon to be set.
test pass 🍏 npm run test
npm run test
BEFORE ALL
Test config app title
APP_NAME
LAUNCH_URL
Launch your own Filmdrop Demo
Launch your own <config value>
Test config app favicon
APP_FAVICON
/public/config
example.config.json
PR Checklist:
Related Issue(s):
Proposed Changes:
configHelper.js
andDoesFaviconExistService
toget-config-service
BOUNS: Add favicon config setting to allow custom favicon to be set.
To test:
test pass 🍏
npm run test
BEFORE ALL
Test config app title
APP_NAME
not in config.jsonLAUNCH_URL
is set in config so Launch button showsLaunch your own Filmdrop Demo
APP_NAME
setting to config.json, and don't set valueLaunch your own Filmdrop Demo
APP_NAME
setting in config.jsonLaunch your own <config value>
Test config app favicon
APP_FAVICON
not in config.jsonAPP_NAME
setting to config.json, and don't set value/public/config
folderAPP_FAVICON
setting in config.json to be same name as file you addedexample.config.json
for formatting - should just be file name without any slashesAPP_FAVICON
setting in config.jsonPR Checklist: