Element84 / filmdrop-ui

A web UI to search and display results from the FilmDrop STAC API.
Other
23 stars 1 forks source link

Ba/feature/relocate popup result #330

Closed bradleyandrick closed 8 months ago

bradleyandrick commented 8 months ago

Related Issue(s):

Proposed Changes:

  1. Move popup results component location to reuse the vertical search LeftContent section of the app
  2. Refactor popup results to remove unnecessary functionality after moving
  3. Add tabbed header in LeftContent layout to handle switching between filtering/search and viewing result details

BONUS 1: adds config option for STAC_LINK_ENABLED to render link out to item in STAC API

BONUS 2: adds config option for SHOW_ITEM_AUTO_ZOOM to render switch that lets user toggle behavior of map center/zooming automatically on selected scene

BONUS 3: refactor loading overlay to specify when it's imagery loading instead of the same generic 'results are loading' spinner graphic that covers whole map when new search or app is loading

BONUS 4: bug fix - when selecting multiple grids from the grid-code aggregation footprint results, only a single grid-code was being shown in popup results when more grid-codes were showing as selected on map

BONUS 5: bug fix - refactor keyboard shortcut for running search again. previously this was just using the space bar keydown BUT this causes error when used in regular patterns - like typing in the geocoder. changed to be ctrl+spacebar

To Test:

Testing steps provided offline in project channel, contact PR author for details

PR Checklist:

philvarner commented 8 months ago

this seems a little off

image

not enough leading, and I can't tell the autozoom is a slider

philvarner commented 8 months ago

"STAC Item:click to view item in STAC API" seems a bit too verbose -- maybe just hyperlink the Title value?

bradleyandrick commented 8 months ago

comments address and discussed offline for: filter spacing & style & stac link