search

Element84 / filmdrop-ui

A web UI to search and display results from the FilmDrop STAC API.
Other
23 stars 1 forks source link

JWT Auth feature #400

Closed bradleyandrick closed 2 months ago

bradleyandrick commented 2 months ago

Related Issue(s):

Proposed Changes:

  1. Adds optional login feature
  2. Adds optional config for ignoring aggregations feature if not supported by the STAC API
  3. Fixes bug with showing scene/item count when Matched is not returned from a STAC API
  4. Changes from MUI Box to use a Stack component to fix build/rendering bug

PR Checklist:

parksjr commented 2 months ago

Just watched the Video overview, thanks for doing that, its really helpful for some easy quick QA without diving in too deep. I have a couple questions/comments after watching that so I'l note them down here, then I am going to dive in deeper to finish the review.

  1. Do you think it could be important to show the logo and/or app title on the login screen?
  2. Minor detail; I think it might be good to get some kind of grey-out, or throbber animation on click of the login button, to prevent that second click, and or N-second wonder if the click worked.
bradleyandrick commented 2 months ago

Just watched the Video overview, thanks for doing that, its really helpful for some easy quick QA without diving in too deep. I have a couple questions/comments after watching that so I'l note them down here, then I am going to dive in deeper to finish the review.

  1. Do you think it could be important to show the logo and/or app title on the login screen?
  2. Minor detail; I think it might be good to get some kind of grey-out, or throbber animation on click of the login button, to prevent that second click, and or N-second wonder if the click worked.

Both of these are now addressed and were demo of features was discussed offline. 🎉