Elemental-IRCd / elemental-ircd

Continuation of ShadowIRCD to meet people's needs

GNU General Public License v2.0

41 stars 19 forks source link

MONITOR metabug #150

Closed Xe closed 9 years ago

Xe commented 9 years ago

[x] Monitor replies should always send a hostmask when available

ariscop commented 9 years ago

ircv3.2 doesn't mention RPL_ENDOFMONLIST in response to MONITOR S, doc/monitor.txt mentions it but pr #151 removes that to match the v3.2 spec

ariscop commented 9 years ago

151 SHOULD also remove the last instances of a hostmask being sent, needs to be checked. tests are updated to not expect it

ariscop commented 9 years ago

After much 'discussion' in #ircv3, it's been decided that the spec is wrong since it doesn't match the majority of implementation, and a hostmask should be sent

RPL_ENDOFMONLIST doesn't seem to be sent by any other implementation, so we won't lest it break MONITOR L

ariscop commented 9 years ago

Fixed by #157