Elemental-IRCd / elemental-ircd

Continuation of ShadowIRCD to meet people's needs
GNU General Public License v2.0
41 stars 19 forks source link

oper-overidden MODE +a message to a channel not being sent to local clients with a opped local client having sent the overridden mode #164

Open ariscop opened 9 years ago

ariscop commented 9 years ago

When all clients are on the same server:

::victim << :kick-2!andrew@127.0.0.1 JOIN #kickland
::chanop << :kick-2!andrew@127.0.0.1 JOIN #kickland
::oper << :kick-2!andrew@127.0.0.1 JOIN #kickland
::victim << :hub.local 353 kick-2 = #kickland {kick-2 kick-1 @kick-0}
::oper >> MODE #kickland +a kick-2
::victim << :hub.local 366 kick-2 #kickland {End of /NAMES list.}
Test timed out

However if oper is on a different server to chanop and victim (in this case hub.local):

::victim >> JOIN #kickland
::victim << :kick-2!andrew@127.0.0.1 JOIN #kickland
::oper << :kick-2!andrew@127.0.0.1 JOIN #kickland
::chanop << :kick-2!andrew@127.0.0.1 JOIN #kickland
::victim << :leaf2.local 353 kick-2 = #kickland {kick-2 !kick-1 kick-0}
::oper >> MODE #kickland +a kick-2
::victim << :leaf2.local 366 kick-2 #kickland {End of /NAMES list.}
::chanop << :kick-0!andrew@127.0.0.1 MODE #kickland +a kick-2
::victim << :kick-0!andrew@127.0.0.1 MODE #kickland +a kick-2
::chanop >> KICK #kickland kick-2 :Test kick!
::chanop << :kick-1!andrew@127.0.0.1 KICK #kickland kick-2 {Test kick!}
::oper << :kick-1!andrew@127.0.0.1 KICK #kickland kick-2 {Test kick!}
::victim << :kick-1!andrew@127.0.0.1 KICK #kickland kick-2 {Test kick!}

@Xe reports that the test passes on her machine

Perhaps this is because it's an oper override?

ariscop commented 9 years ago
<ariscop> yet on travis osx it fails?
<Xena> what osx is travis osx?
<ariscop> http://docs.travis-ci.com/user/osx-ci-environment/
<ariscop> Travis CI uses OS X 10.9.5.
<Xena> i'm using 10.10.5
Xe commented 9 years ago

here's the bugger

Xe commented 9 years ago

This worked on my machine because I had another server-local client in the channel.