Avoid checkSet for server notice setting, as it ignores the mode permission

ElementalAlchemist / txircd

Modular IRCd built using Twisted. Made to be extremely customizable.

BSD 3-Clause "New" or "Revised" License

19 stars 5 forks source link

Closed Heufneutje closed 10 years ago

ElementalAlchemist commented 10 years ago

I'd have just implemented modechanged-user-s directly.

Typically, implementing modeactioncheck and running it as a mode implies there are some conditions for it to run, which there aren't here. It increases complexity without gain.
Your modeactioncheck name is wrong and will never be called.
Your modeactioncheck wouldn't have happened anyway if it was right because you forgot to put any actions in the mode's affectedActions.