search

ElementsProject / ELIPs

Elements Improvement proposals
12 stars 11 forks source link

Deterministic Descriptor Blinding Keys ELIP #8

Closed LeoComandini closed 10 months ago

jgriffiths commented 12 months ago

LGTM thanks, ack.

apoelstra commented 11 months ago

c52c80d9fd82f9f1471c77255c443d7096fa4e6b lgtm. Just two minor comments.

apoelstra commented 11 months ago

Assigned ELIP 151.

Having said this, my original vision was that people would achieve this by choosing otherwise-unused BIP32 paths and then combining their keys using musig or something. But given that this is currently unspecified (ELIP 150 says Later extensions to this ELIP may specify alternate expressions...) I think this is a simple and good alternative.

LeoComandini commented 11 months ago

Addressed review comments and used assigned elip number in the last commit, will squash it later

apoelstra commented 11 months ago

Looks great!

LeoComandini commented 11 months ago

will squash and update after #9 is merged (or abandoned/nacked)

LeoComandini commented 11 months ago

Rebased, updated and squashed. Also updated reference impl https://github.com/ElementsProject/elements-miniscript/pull/61

LeoComandini commented 10 months ago

@apoelstra do we need more work/review on this? or it can be merged? related ref impl was merged https://github.com/ElementsProject/elements-miniscript/pull/61

apoelstra commented 10 months ago

I think we can merge it.