ElementsProject / elements

Open Source implementation of advanced blockchain features extending the Bitcoin protocol
MIT License
1.04k stars 369 forks source link

signmessage #1319

Open LeoComandini opened 4 months ago

LeoComandini commented 4 months ago

There are a few issues/open points with Elements/Liquid signmessage and verifymessage

Are we ok with all of the above? or do we we want to change something?

Do we still want to support message signing in Core?

Do we want to extend message signing and verification to non-p2pkh? Do we want to do it outside Core?


FWIW, here is a summary of what some existing wallets implement

Core GDK Electrum
signmessage bitcoin p2pkh
signmessage bitcoin p2sh-p2wpkh
signmessage bitcoin p2wpkh
verifymessage bitcoin p2pkh
verifymessage bitcoin p2sh-p2wpkh
verifymessage bitcoin p2wpkh
signmessage liquid p2pkh
signmessage liquid p2sh-p2wpkh
signmessage liquid p2wpkh
verifymessage liquid p2pkh
verifymessage liquid p2sh-p2wpkh
verifymessage liquid p2wpkh

Electrum was included in the above table since it was used as a reference to add support for non-p2pkh signing to GDK.

jmastr commented 4 months ago

@LeoComandini Thank you so much for kick starting the discussion here and putting in the effort to create this table. Highly appreciated.