search

ElementsProject / elements

Open Source implementation of advanced blockchain features extending the Bitcoin protocol
MIT License
1.05k stars 375 forks source link

Inconsistent naming in the application #667

Open nwoodfine opened 5 years ago

nwoodfine commented 5 years ago

1) The application is called Elements Core but shows Liquid logo, would benefit from standardisation to avoid confusion. 2) When running Liquid Core for first time, dialog says welcome to Elements Core, and tells me that it will download and store a copy of the Bitcoin block chain - pretty sure this is referring to Liquid blockchain - this is obviously very confusing. Liquid is not even mentioned. 3) Same dialog box says the Bitcoin blockchain is 1GB big, containing transaction data from 2009 - specific naming of blockchain size seems risky if not dynamically generated, will go out of date quick.

I was downloading Liquid binaries, so expected to see application called Liquid Core, and dialog reference to the Liquid block chain (sidechain).

image

Version: liquid-0.17.0-osx-unsigned.dmg

stevenroose commented 4 years ago

The Elements Core vs Liquid is I think as we intend it to be. "Elements Core" is the software, "Liquid" is the network. So liquid-qt or "Liquid Core" doesn't exist anymore.

But the mentions of the Bitcoin blockchain are an issue. We traverse the code often for mentions of Bitcoin, and we often let one slip here or there.

Translation files make that task a whole lot harder still.

stevenroose commented 4 years ago

There's plenty of unhandles Bitcoin name mentions and it would be quite intensive to go over all of them:

$ rg -tcpp "\".*Bitcoin.*\"" src/qt | wc -l
56

It might be worth it to go over all those within strings.