search

ElementsProject / lightning-charge

A simple drop-in solution for accepting lightning payments
MIT License
554 stars 80 forks source link

Compatibility with Core-Lightning v23.05 #91

Closed darosior closed 1 year ago

darosior commented 1 year ago

Since upgrading to 23.05.2, lightning-charge seems to be stuck at startup.

I tried running the tests, and it seems stuck at "Setting up charged":

 npm test                                                                                                                                                                                                                                                                                                                       

> lightning-charge@0.4.23 test                                                                                                                                                                                                                                                                                                                                             
> bin/test.sh                                                                                                                                                                                                                                                                                                                                                              

Setting up test envirnoment in /tmp/tmp.D9D61Gmr6V                                                                                                                                                                                                                                                                                                                         
Setting up bitcoind                                                                                                                                                                                                                                                                                                                                                        
Setting up lightningd                                                                                                                                                                                                                                                                                                                                                      
Setting up charged                                                                                                                                                                                                                                                                                                                                                         

^C

(Terminated it after >10min)

nitramiz commented 1 year ago

+1. Starting the daemon doesn't do anything after upgrading to CLN v23.05.2. Only shows a blank screen.

darosior commented 1 year ago

cc @shesek

shesek commented 1 year ago

Hi! Thanks for the report and apologies for taking long to get to this.

This should be fixed with the v0.4.24 release. It's up on NPM and will shortly be available on Docker Hub too.

shesek commented 1 year ago

The amd64 docker images are up. There's an issue with the armv7/8 ones, I'm working on a fix.

nitramiz commented 1 year ago

Thanks a lot! Tested and Charge is working again!

shesek commented 1 year ago

v0.4.25 was released with a fix for the arm docker images, which are now available on docker hub.