search

ElementsProject / lightning

Core Lightning — Lightning Network implementation focusing on spec compliance and performance
Other
2.84k stars 901 forks source link

plugin-bcli returning "\n" instead of line break in the logfile #4912

Open guibressan opened 2 years ago

guibressan commented 2 years ago

v0.10.2

Steps to Reproduce

bitcoind process got killed with lightningd running

lightning logfile output

Screen Shot 2021-11-08 at 21 56 12
ZmnSCPxj commented 2 years ago

This occurs for all plugins. Is it really that much of a concern?

vincenzopalazzo commented 2 years ago

This occurs for all plugins. Is it really that much of a concern?

Not important I think because the console should be formatted fine (?). However, maybe on the file, we can make some trick to split the string by "\n" token to make easy the human parsing of the file?

ZmnSCPxj commented 2 years ago

Seems a an easy thing to do, probably should hook somewhere in lightningd/log.c, so that all logging does this?

guibressan commented 2 years ago

This occurs for all plugins. Is it really that much of a concern?

This is just a little inconvenient. I can understand the information perfectly.

vincenzopalazzo commented 2 years ago

Seems a an easy thing to do, probably should hook somewhere in lightningd/log.c, so that all logging does this?

@ZmnSCPxj I can make some experiments later this week, and report there the result.

This is just a little inconvenient. I can understand the information perfectly.

BTW, we can try to improve this error message, thanks to report this

ecurrencyhodler commented 9 months ago

Hello! @starius submitted PR #7013 for this issue which was posted as a bounty: https://community.sphinx.chat/bounty/1214

Would it be okay to assign him the issue and review his pr?