ElementsProject / lightning

Core Lightning — Lightning Network implementation focusing on spec compliance and performance
Other
2.85k stars 902 forks source link

Cannot reparse offerstr from db #5093

Open heyambob opened 2 years ago

heyambob commented 2 years ago

Issue and Steps to Reproduce

I'm getting this line, about 4 times a day:

2022-03-14T14:29:47.539Z **BROKEN** lightningd: Cannot reparse offerstr from db lno1pqp2gyq2r4xxjen99ss92mnfwejhyum9ypskuepqg4mx2unew35xjmn8rcsp7kluxd0ff8j4t6f6z5etvu9r0mmny4qs6f5qledgeayralckrc3kqrcyq89ztwn7m26rqz5xzk7flpha3k5hmx67h7lp6nxdd8q0yv6dvz3wwd3scuvpgpw7fqs4tqd4syknnhf65vyrux8yv8psfa4drv72cvnq: Invalid signature

How it happened ? I do not know but I used to play with Bolt12 when it came out. Now my listoffers shows:

{
   "offers": [
      {
         "offer_id": "1d3681eb4b228ba1f283ae84235fbec7e442d7e817703dd21a3c7a26c805bcef",
         "active": false,
         "single_use": false,
         "bolt12": "lno1pqp2gyq2r4xxjen99ss92mnfwejhyum9ypskuepqg4mx2unew35xjmn8rcsp7kluxd0ff8j4t6f6z5etvu9r0mmny4qs6f5qledgeayralckrc3kqrcyq89ztwn7m26rqz5xzk7flpha3k5hmx67h7lp6nxdd8q0yv6dvz3wwd3scuvpgpw7fqs4tqd4syknnhf65vyrux8yv8psfa4drv72cvnq",
         "used": false
      },
      {
         "offer_id": "f9b4a2184cdfdf810282ede788f7e78e4c19b7c4654775fe533f6605d042fcae",
         "active": false,
         "single_use": true,
         "bolt12": "lno1pqpsrz5gpgv5ymmvwscnygrnv4hxghmfdemx76trv5s8gmmjvd5quprpxdcqy83qp5tp0cn6cq3rj56j72ehwjtfty7n6mwl7ma3zlvzp2wa4rdy2gtnvq8sgphcxewyh0v0st5kymntesa7ydvvywg8mmd3catwsr56e3hlem8hm6v38c60y9z96876867stwjk4rkskn3halsypy56cjanvgu4xmm2",
         "bolt12_unsigned": "lno1pqpsrz5gpgv5ymmvwscnygrnv4hxghmfdemx76trv5s8gmmjvd5quprpxdcqy83qp5tp0cn6cq3rj56j72ehwjtfty7n6mwl7ma3zlvzp2wa4rdy2gtnvqq",
         "used": false
      }
   ]
}

getinfo output

   "version": "v0.10.2-456-ga2a6b8c",
   "blockheight": 727324,
   "network": "bitcoin",
   "our_features": {
      "init": "80282a6aa2",
      "node": "800080282a6aa2",
      "channel": "",
      "invoice": "20024200"
   }
rustyrussell commented 2 years ago

Ah, you can ignore this! The spec for offers is still in draft, and changes. These are old offers we can no longer read, since the format changed.

heyambob commented 2 years ago

I see. Can it be purged from db ? I don't see a way to delete it from the lightning-cli command

vincenzopalazzo commented 2 years ago

I see. Can it be purged from db ? I don't see a way to delete it from the lightning-cli command

I need to remove my old PR to do that https://github.com/ElementsProject/lightning/pull/4745 for the moment we have no way to delete an offer!