search

ElementsProject / lightning

Core Lightning — Lightning Network implementation focusing on spec compliance and performance
Other
2.81k stars 890 forks source link

Installation: launchpadlib's dependence on testresources causes error. #5131

Open dscotese opened 2 years ago

dscotese commented 2 years ago

Issue and Steps to Reproduce

  1. Be running C-Lightning v0.8.1-2401-g4ae9e0c on Ubuntu 20.04.3 LTS \n \l
  2. Follow these instructions from the Ubuntu section of the installation page: 
    sudo apt-get install -y \
autoconf automake build-essential git libtool libgmp-dev libsqlite3-dev \
python3 python3-pip net-tools zlib1g-dev libsodium-dev gettext
pip3 install --upgrade pip
pip3 install --user poetry
  3. See if you get ERROR: launchpadlib 1.10.13 requires testresources, which is not installed.

I believe the fix is (from https://gist.github.com/y56/0540d22a1db40dacc7fbbb93c866821e) to add this line to the instructions above: sudo apt install python3-testresources (or add it to the apt-get install command so it auto-answers Yes to the prompt(s?) )

vincenzopalazzo commented 2 years ago

Be running C-Lightning v0.8.1-2401-g4ae9e0c on Ubuntu 20.04.3 LTS \n \l

This is a typo here, right? the version of c-lighnting is v0.10?

I believe the fix is (from https://gist.github.com/y56/0540d22a1db40dacc7fbbb93c866821e) to add this line to the instructions above: sudo apt install python3-testresources (or add it to the apt-get install command so it auto-answers Yes to the prompt(s?) )

Concept ACK

cdecker commented 2 years ago

The version tag is kinda old, but that's most likely because the repo was cloned without pulling in the tags (which are needed to determine what the latest release tag is). The commit is from May 23, 2021, so also not really up to date. Where did you get that snapshot from? Seems way outdated.

dscotese commented 2 years ago

I only indicated that I was running that version because it implies some state of my machine and the software on it, which might contribute to the Error. I don't believe it matters otherwise. For example, it may be the case that I skipped a version which would have installed what was missing. In fact, it's probably irrelevant that I was already running c-lightning, as the instructions I was following come before even getting the source code.