ElementsProject / lightning

Core Lightning — Lightning Network implementation focusing on spec compliance and performance
Other
2.83k stars 899 forks source link

test_mpp_overload_payee (memleak in wallet_stmt2invoice_details) #5535

Open niftynei opened 2 years ago

niftynei commented 2 years ago

E Node errors: E Global errors: E - Node /tmp/ltests-rcp5w_ss/test_mpp_overload_payee_1/lightning-2/ has memory leaks: [ E { E "backtrace": [ E "ccan/ccan/tal/tal.c:442 (talalloc)", E "wallet/invoices.c:81 (wallet_stmt2invoice_details)", E "wallet/invoices.c:697 (invoices_get_details)", E "wallet/wallet.c:2946 (wallet_invoice_details)", E "lightningd/invoice.c:1296 (json_add_invoices)", E "lightningd/invoice.c:1370 (json_listinvoices)", E "lightningd/jsonrpc.c:625 (command_exec)", E "lightningd/jsonrpc.c:762 (rpc_command_hook_final)", E "lightningd/plugin_hook.c:279 (plugin_hookcall)", E "lightningd/jsonrpc.c:850 (plugin_hook_call_rpc_command)", E "lightningd/jsonrpc.c:954 (parse_request)", E "lightningd/jsonrpc.c:1051 (read_json)", E "ccan/ccan/io/io.c:59 (next_plan)", E "ccan/ccan/io/io.c:435 (io_do_always)", E "ccan/ccan/io/poll.c:304 (handle_always)", E "ccan/ccan/io/poll.c:385 (io_loop)", E "lightningd/io_loop_with_timers.c:22 (io_loop_with_timers)", E "lightningd/lightningd.c:1195 (main)", E "../csu/libc-start.c:308 (__libc_start_main)" E ], E "label": "wallet/invoices.c:81:struct invoice_details", E "parents": [ E "common/json_stream.c:41:struct json_stream", E "ccan/ccan/io/io.c:91:struct io_conn NOTLEAK", E "lightningd/lightningd.c:107:struct lightningd" E ], E "value": "0x5571b407a708" E } E ]

SimonVrouwe commented 2 years ago

I hit the same memory leak via test_partial_payment_restart