Now pay crashes CLN-master all the time

hMsats commented 1 year ago

Issue and Steps to Reproduce

Node 1: lightning-cli invoice 20000 hi4 hi4

{
   "payment_hash": "1648d48a9f3d5b30ea1082711b0f284934b81954b338753e53982b030de374c4",
   "expires_at": 1691049510,
   "bolt11": "lnbc200n1pjvygaxsp5kmpqmkf4au2dx4msk668ydt6l8vufdnms00gvkmlka6fksygj72qpp5zeydfz5l84dnp6sssfc3kregfy6tsx25kvu820jnnq4sxr0rwnzqdq9dp5ngxqyjw5qcqpjrzjq2ygy3qzn3vsjkfs8z43nunfj378yr0rgglyj9u3k3k8eyhhvfumvrqzagqq9hsqqqqqqqqqqqqqqqqqyg9qxpqysgqlgwxuqxeqn3mpxhhfd4vsns625yav87ema78qlaztxa2cxvj8df98s8v4qtzvjynjnpwshudfnh863pu0kudc2syuftqfw8skj857tcqu9t3fx",
   "payment_secret": "b6c20dd935ef14d35770b6b472357af9d9c4b67b83de865b7fb7749b40889794",
   "created_index": 203
}

Node 2: lightning-cli pay lnbc200n1pjvygaxsp5kmpqmkf4au2dx4msk668ydt6l8vufdnms00gvkmlka6fksygj72qpp5zeydfz5l84dnp6sssfc3kregfy6tsx25kvu820jnnq4sxr0rwnzqdq9dp5ngxqyjw5qcqpjrzjq2ygy3qzn3vsjkfs8z43nunfj378yr0rgglyj9u3k3k8eyhhvfumvrqzagqq9hsqqqqqqqqqqqqqqqqqyg9qxpqysgqlgwxuqxeqn3mpxhhfd4vsns625yav87ema78qlaztxa2cxvj8df98s8v4qtzvjynjnpwshudfnh863pu0kudc2syuftqfw8skj857tcqu9t3fx

{
   "code": -4,
   "message": "Plugin terminated before replying to RPC call."
}

pay: FATAL SIGNAL 11 (version v23.05-441-g435a462)
0x560ad011c338 send_backtrace
        common/daemon.c:33
0x560ad011c3d2 crashdump
        common/daemon.c:75
0x7f811f16f08f ???
        /build/glibc-SzIz7B/glibc-2.31/signal/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
0x560ad010b435 local_channel_hints_listpeerchannels
        plugins/libplugin-pay.c:2408
0x560ad0105b80 handle_rpc_reply
        plugins/libplugin.c:871
0x560ad0105d00 rpc_read_response_one
        plugins/libplugin.c:1048
0x560ad0105da2 rpc_conn_read_response
        plugins/libplugin.c:1072
0x560ad01b57c5 next_plan
        ccan/ccan/io/io.c:59
0x560ad01b5c92 do_plan
        ccan/ccan/io/io.c:407
0x560ad01b5d2f io_ready
        ccan/ccan/io/io.c:417
0x560ad01b6f6b io_loop
        ccan/ccan/io/poll.c:453
0x560ad0105fe4 plugin_main
        plugins/libplugin.c:1949
0x560ad0101c10 main
        plugins/pay.c:1314
0x7f811f150082 __libc_start_main
        ../csu/libc-start.c:308
0x560ad00fee2d ???
        ???:0
0xffffffffffffffff ???
        ???:0
2023-07-27T07:58:47.244Z INFO    plugin-pay: Killing plugin: exited during normal operation
2023-07-27T07:58:47.244Z **BROKEN** plugin-pay: Plugin marked as important, shutting down lightningd!

`getinfo` output

Node 1: v23.05-441-g435a462

Node 2: v23.05-441-g435a462

hMsats commented 1 year ago

@cdecker Added your changes in libplugin-pay.c and that solved it. Impressive!

hMsats commented 1 year ago

@vincenzopalazzo please add flag bug

ElementsProject / lightning