search

ElementsProject / lightning

Core Lightning — Lightning Network implementation focusing on spec compliance and performance
Other
2.85k stars 902 forks source link

Testing: constrain experimental-splicing to specific peers / channels #6614

Open Sjors opened 1 year ago

Sjors commented 1 year ago

Some people might be more willing to try out splicing if they know it can only destroy one specific (small) channel. So it'd be nice to have a way to specify that in the config.

rustyrussell commented 1 year ago

Hmm, hmm...

We can add a channel_type arg to fundchannel, but what about the accepter side? Did you want an option to accept from anyone, but not offer?

Sjors commented 1 year ago

What I had in mind was that the node just pretends to not support splicing, unless the peer is on a while list. Alternatively, if that's easier, unless the channel is on a white list.

Sjors commented 1 year ago

(I'm assuming based on glancing over the spec that we just announce splicing support as a flag, but not sure if we do that as a general announcement to a peer, or per channel, or if we gossip it around the planet)

rustyrussell commented 1 year ago

Sorry, brain fart

Yes, for splicing we need both peers to indicate support in their init messages. We could change what we present on a per-peer basis, hmm