ElementsProject / lightning

Core Lightning — Lightning Network implementation focusing on spec compliance and performance
Other
2.81k stars 887 forks source link

RBF onchain of a tx that does not exists. #7206

Open Tracachang opened 5 months ago

Tracachang commented 5 months ago

Issue and Steps to Reproduce

Hello,

I am using lightning core v24.02.1.

I had a force closed channel with an active HTLC, funds were sent to from bc1qca5lwlfv8qzkchcfqdryfl89szuk2n0c3x2p7vt4gst04keygkns4x68hh to my address (bc1qf7nh8pwt30nxueqekrhapa3wyz98zxu58rfl8l) and 3 days later, the HTLCe expired was sent to the same address bc1qca5lwlfv8qzkchcfqdryfl89szuk2n0c3x2p7vt4gst04keygkns4x68hh and it seems to be stuck.

Since then I see in logs that it is trying to RBF onchain a tx that does not exists non stop:

Apr 08 21:00:13 nixos lightningd[1311]: UNUSUAL 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: Peer permanent failure in ONCHAIN: Funding transaction spent Apr 08 21:00:13 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: State changed from ONCHAIN to FUNDING_SPEND_SEEN Apr 08 21:00:13 nixos lightningd[1311]: INFO lightningd: -------------------------------------------------- Apr 09 16:30:10 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid e20430064a0c8a7f3f6032e555054c68e37b340409456b7fd60e7c0bc6b4e451 (fee 194sat) with txid a1ebed749f7cc64bebfa53e5a4cb9ecb629d9cf53ea4ced43ad0db7e0436e389 (fee 363sat) Apr 09 16:30:51 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid a1ebed749f7cc64bebfa53e5a4cb9ecb629d9cf53ea4ced43ad0db7e0436e389 (fee 363sat) with txid 8753c0ff777882ac66303f4c81bf4eab2aa17c7e10d55b4f4a337567ae4d21fa (fee 402sat) Apr 09 16:31:29 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid 8753c0ff777882ac66303f4c81bf4eab2aa17c7e10d55b4f4a337567ae4d21fa (fee 402sat) with txid 30e9fd83a2cbb6333ba4693b7d4648e4e6dde053ccdc694b8cecc0c908ee74cc (fee 423sat) Apr 09 16:35:08 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid 30e9fd83a2cbb6333ba4693b7d4648e4e6dde053ccdc694b8cecc0c908ee74cc (fee 423sat) with txid f6c0cc8517529ce32c557d2c6e254645e54ec1f82d2e29fd7fec77c126dd1c9e (fee 426sat) Apr 09 16:35:55 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid f6c0cc8517529ce32c557d2c6e254645e54ec1f82d2e29fd7fec77c126dd1c9e (fee 426sat) with txid 4947e04fef4bcbdb724f5ee83deec5e0691ebf54aa53bf726e413ceb241cf91d (fee 484sat) Apr 09 16:39:07 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid 4947e04fef4bcbdb724f5ee83deec5e0691ebf54aa53bf726e413ceb241cf91d (fee 484sat) with txid e2f452eaa6c9ab52631f35af7c3af543be2bfb1abc04d9d4542e2d2465b56637 (fee 491sat) Apr 09 16:45:02 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid 03b1b15772747ea70f28254656bd0aecff23153f649612c9eb5bdbc8cae52f38 (fee 489sat) with txid 148dbb77529618e46a107134263991d361dbf7e7577622e02ed853c6fcde1f60 (fee 496sat) Apr 09 16:46:47 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid 148dbb77529618e46a107134263991d361dbf7e7577622e02ed853c6fcde1f60 (fee 496sat) with txid 56269639f3b872cf43c1b3c04a64fa57d9f070c8faeb23e9aa2935971e6e3cc9 (fee 499sat) Apr 09 16:47:41 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid 56269639f3b872cf43c1b3c04a64fa57d9f070c8faeb23e9aa2935971e6e3cc9 (fee 499sat) with txid 5f56eea9fb1b690cd29b24dff77af430bd56600fbe8995d1753fee177ebaad09 (fee 561sat) Apr 09 16:48:16 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid 5f56eea9fb1b690cd29b24dff77af430bd56600fbe8995d1753fee177ebaad09 (fee 561sat) with txid 881b4fee785680c5a8a98245db876c0c3b81ce57a0c9f5467626d2d185eea631 (fee 572sat) Apr 09 16:49:28 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid 881b4fee785680c5a8a98245db876c0c3b81ce57a0c9f5467626d2d185eea631 (fee 572sat) with txid 1a6e3deae273b20ec768b9256d2a266302f6b02331db8036b8e879eec8406024 (fee 574sat)

lightning-cli listpeers:

`"status": [ "ONCHAIN:Tracking our own unilateral close", "ONCHAIN:2 outputs unresolved: waiting confirmation that we spent DELAYED_OUTPUT_TO_US (19e3daf96f323d3bd5b0b5de0bba690d50e51c9e8ce894bdd4d7167763203dff:1) using OUR_DELAYED_RETURN_TO_WALLET

                 "direction": "out",
                 "id": 594,
                 "amount_msat": 34149577,
                 "expiry": 837088,
                 "payment_hash": "2af8b9258f39b5594c67c68140ab2e3f2864ed2f75b334473e19da8135d1a368",
                 "state": "SENT_ADD_ACK_REVOCATION"

` lightning-cli listtransactions:

{ "hash": "0e8f317ae114c422295a64e08b477633cbecbb0c4e0a49f80cd0958ad89be97b", "rawtx": "02000000000101ff3d20637716d7d4bd94e88c9e1ce5500d69ba0bdeb5b0d53b3d326ff9dae3190100000000f00000000147900000000000001600144fa77385cb8be66e6419b0efd0f62e208a711b940347304402205ce00ecebf0c4dabbb1523b24d5472d6c3c2542a2b02a11e9b022b7640b9b43e022050686891b55ad6a1daefbb2f41fb6fd7b8d695b8388939b96b6223f84d96920b01004d632103fd5d6af3e90c1f1f6c4980520b02937b68dbe5939e2401206ec45c17d06bdd8d6702f000b27521024af7c8cbcbe85ffaa4d3057f6573aabc97090247c371099fed96ab5ffac2edfe68ac00000000", "blockheight": 836722, "txindex": 225, "locktime": 0, "version": 2, "inputs": [ { "txid": "19e3daf96f323d3bd5b0b5de0bba690d50e51c9e8ce894bdd4d7167763203dff", "index": 1, "sequence": 240 } ], "outputs": [ { "index": 0, "amount_msat": 36935000, "scriptPubKey": "00144fa77385cb8be66e6419b0efd0f62e208a711b94" } ] },

{ "hash": "599b95c2b03dc2ee4a8598014ab56f91c9cd46fec99559e181a7a34a43ae07ef", "rawtx": "02000000000101ff3d20637716d7d4bd94e88c9e1ce5500d69ba0bdeb5b0d53b3d326ff9dae31900000000000000000001157b000000000000220020c769f77d2c38056c5f09034644fce580b9654df889941f31754416fadb2445a70500483045022100c7ebe159fa8f17908d3bd09cef3d8ad0c61b7820af70cba06bc7697b8243494a02206b7b864c52019ea3a26f00bff2ef4cb15cc378a28124e3356be0ecc70817cf2f0147304402202f12e3627d1a48084ec49c1fc3ccfb495bcad1b1529a29312ac017d6e38200a802203c90e7cba16ee55449458477dfd5614794d5989850cd7cbba081e42d9efc750301008576a9143d0339528b3e0b234d55d0c0bac2d6818a1786828763ac672103f9caafa22f9f8333103bc39c4283d79c64ce0f13985afab65d31176092a790df7c820120876475527c2102dac1c967a4f2dae76664015298ed4fa8efff351780c048b7528be0feaa210b8152ae67a914c7bd4cd1b957fedad1a5950a051bd432110a72c488ac6868e0c50c00", "blockheight": 837114, "txindex": 1482, "locktime": 837088, "version": 2, "inputs": [ { "txid": "19e3daf96f323d3bd5b0b5de0bba690d50e51c9e8ce894bdd4d7167763203dff", "index": 0, "sequence": 0 } ], "outputs": [ { "index": 0, "amount_msat": 31509000, "scriptPubKey": "0020c769f77d2c38056c5f09034644fce580b9654df889941f31754416fadb2445a7" } ] },

Tracachang commented 5 months ago

RBF keeps increasing, actually 2900 sat:

Apr 10 11:34:10 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid def1e5d6d3e0297a32bf8fede28b2585bac8592917f32aece9e61f375eaf3b71 (fee 1692sat) with txid 7b26b874b0ea1426ea032dd5289f15ee7c604cb1053ff8c610af4a73cb14b767 (fee 1705sat) Apr 10 11:35:05 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid 7b26b874b0ea1426ea032dd5289f15ee7c604cb1053ff8c610af4a73cb14b767 (fee 1705sat) with txid c16b1aeac891f5686e75af0099e8c5587d4198eda9cbe23b608bfdc06c20ecfc (fee 2194sat) Apr 10 11:40:47 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid c16b1aeac891f5686e75af0099e8c5587d4198eda9cbe23b608bfdc06c20ecfc (fee 2194sat) with txid 4bcd2fc6facb50b40d65a62cee7510a2e36a1688a1dad3fc25c33ed67743f749 (fee 2216sat) Apr 10 11:41:36 nixos lightningd[1311]: INFO 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: RBF onchain txid 4bcd2fc6facb50b40d65a62cee7510a2e36a1688a1dad3fc25c33ed67743f749 (fee 2216sat) with txid c83aa564ae8e7c12a09ffcd1961d1c62e5ba6d8f049c94e070d524206f70f9b4 (fee 2900sat)

Tracachang commented 5 months ago

Finally I was able to find the raw transaction in the debug logs (which was never broadcasted) and manually broadcast it. After that it was RBF and included in a block.

This seems to be the reason why my logs were full of RBF on chain, increasing fees and keep trying to RBF of an "inexistant tx", simply because the first transaction was never broadcasted. It says deferring until block 837353 but that never happened.

DEBUG 021cb32426ed1a6be9533801e7c56a70ffc1c360a3a31819c3ae0a72e141d78000-chan#6: Broadcast for onchaind tx 02000000000101ef07ae434aa3a781e15995c9fe46cdc9916fb54a0198854aeec23db0c2959b590000000000f0000000019b7a0000000000001600144fa77385cb8be66e6419b0efd0f62e208a711b940347304402203b461147ebd330c7ed422dcbec2b2e98ba9345ef34939662027ce7495f8b31ab02206553af841763c16ef0f398dcb2e62db19ff4c6859a70ea10be529aca8ef8710701004d632103fd5d6af3e90c1f1f6c4980520b02937b68dbe5939e2401206ec45c17d06bdd8d6702f000b27521024af7c8cbcbe85ffaa4d3057f6573aabc97090247c371099fed96ab5ffac2edfe68ac00000000 DEBUG lightningd: Deferring broadcast of txid 40dc7b5325fc335850da6a8f56eed00c7403e523e7679c8050433b22c08e3bca until block 837353