search

ElementsProject / lightning

Core Lightning — Lightning Network implementation focusing on spec compliance and performance
Other
2.82k stars 896 forks source link

`lightnind` is missing CLI options on darwin #7241

Open plebhash opened 5 months ago

plebhash commented 5 months ago

I need to run clightning on my darwin setup. More specifically, I need to call lightningd --bitcoin-datadir=${bitcoin_dir}.

However, this CLI option is not available on the darwin build.

Steps To Reproduce

Steps to reproduce the behavior (on darwin):

$ lightningd --bitcoin-datadir=.
2024-04-18T13:47:28.658Z INFO    lightningd: v24.02.1
lightningd: --bitcoin-datadir=.: unknown option

I tested with installations both via:

Expected behavior

Here's the expected behavior (validated on linux):

$ lightningd --bitcoin-datadir=.
2024-04-18T13:48:45.580Z INFO    lightningd: Creating database
2024-04-18T13:48:45.604Z UNUSUAL hsmd: HSM: created new hsm_secret file
...
vincenzopalazzo commented 5 months ago

What happens if you pass down lightningd --bitcoin-datadir=$(pwd)?

Not sure the . we resolve the period symbol

plebhash commented 5 months ago

same behavior:

$ lightningd --bitcoin-datadir=$(pwd)
2024-04-20T15:06:46.340Z INFO    lightningd: 24.02.2
lightningd: --bitcoin-datadir=/Users/plebhash/.bitcoin: unknown option

the point is that --bitcoin-datadir is not available on the binary, it doesn't even show up on --help listed options

vincenzopalazzo commented 5 months ago

Sorry I read the error in the wrong way, how you do install the plugin? this error can be possible if your build system is not including bcli plugin

plebhash commented 5 months ago

I didn't build this from source, I just grabbed it via nix and brew. Both options presented this issue.

vincenzopalazzo commented 5 months ago

well nix has build it from source, so we should have a way to reproduce it

plebhash commented 5 months ago

cross referencing: https://github.com/NixOS/nixpkgs/issues/305060#issuecomment-2077452590

cdecker commented 3 months ago

Notice that the option is added by bcli so either that plugin no longer has that option, you're using another backend or we're calling a bitcoin-cli that doesn't understand that option anymore (no idea how that'd happen).