search

ElementsProject / lightning

Core Lightning — Lightning Network implementation focusing on spec compliance and performance
Other
2.81k stars 887 forks source link

Build: Skip contrib/pyln-grpc-proto ? #7282

Open IngwiePhoenix opened 4 months ago

IngwiePhoenix commented 4 months ago

Issue and Steps to Reproduce

Hello there,

I am trying to migrate my btc/cln stack into an incus Alpine 3.19 container, however I am facing issues while building v24.02.2: grpc_tools.protoc is missing, and while APK provides py3-grpcio, it does not provide py3-grpcio-tools. Thus, this particular module can not be built.

Hence, I would like to skip it. Is there a way - like a configure flag - I can do that?

Thanks!

getinfo output

None; my node is offline. Migrated from my previous setup with OpenWrt to Debian and Alpine in Incus as part of the Kubernetes-restructure of my network.

Kind regards, Ingwie

vincenzopalazzo commented 4 months ago

Concept ack for this, compile cln on odroid is a very log process due the grpc depencencies

daywalker90 commented 4 months ago

i believe there is a flag to disable building the rust crates, something like ./configure --disable-rust iirc

IngwiePhoenix commented 4 months ago

Yes, you can en- or disable rust; but you can not do the same for the gRPC stuff, let alone for the Python modules - which I personally see no use for except perhaps for the built-in REST API, which in return doesn't need any of the gRPC stuff either as it is launched as a plugin that consumes STDIN/STDOUT.

daywalker90 commented 4 months ago

the grpc stuff IS only from building the rust crate cln-grpc, i'm pretty sure i did not need a protoc compiler or grpc dependencies if i did not build that crate

vincenzopalazzo commented 4 months ago

@daywalker90 are you sure that it is not required also by pyln-client? I remember some hidden dependencies