ElementsProject / lightning

Core Lightning — Lightning Network implementation focusing on spec compliance and performance
Other
2.81k stars 889 forks source link

renepay fell over #7516

Open niftynei opened 1 month ago

niftynei commented 1 month ago

first i tried to pay an invoice with any amount

[nifty@pps:~]$ lightning-cli renepay LNBC1PN2...RTR 400000
# Sent route request: partid=1 amount=400000msat prob=1.000 fees=1040msat delay=442 path=<redacted>
# Sent route request: partid=2 amount=400000msat prob=1.000 fees=1040msat delay=442 path=<redacted>
# Sent route request: partid=3 amount=400000msat prob=1.000 fees=1040msat delay=442 path=<redacted>
# Sent route request: partid=4 amount=400000msat prob=1.000 fees=1040msat delay=442 path=<redacted>
# Sent route request: partid=5 amount=400000msat prob=1.000 fees=1040msat delay=482 path=<redacted>
# Sent route request: partid=6 amount=400000msat prob=1.000 fees=1040msat delay=442 path=<redacted>
# Sent route request: partid=7 amount=400000msat prob=1.000 fees=1040msat delay=442 path=<redacted>
# Sent route request: partid=8 amount=400000msat prob=1.000 fees=1040msat delay=442 path=<redacted>
# Sent route request: partid=9 amount=400000msat prob=1.000 fees=1040msat delay=442 path=<redacted>
{
   "code": 210,
   "message": "Timed out"
}

then i try it again, except with 400k sats, not 400. now it says it can't find the destination!

[nifty@pps:~]$ lightning-cli renepay LNBC1PN2...4RTR 400000sat{
   "code": 205,
   "message": "Destination is unknown in the network gossip."
}

then i try the same command again, and it says the plugin has died.

[nifty@pps:~]$ lightning-cli renepay LNBC1PN2CD...6T4RTR 400000sat
# Sent route request: partid=1 amount=400000msat prob=1.000 fees=1040msat delay=442 path=<redacted>
{
   "code": -4,
   "message": "Plugin terminated before replying to RPC call."
}

current version of core-lightning: "version": "v24.05",

Lagrang3 commented 1 month ago

The any amount is irrelevant. The fact that paths are not reliable, that's a hard problem I am trying to figure out. In the most recent updates (PR #7403 is at the top of my developing branch, still to be merged) I fixed some bugs that could have crashed the plugin in the way you have described. I still get sometimes the Destination is unknown in the network gossip. message. Let me investigate.