search

ElementsProject / lightning

Core Lightning — Lightning Network implementation focusing on spec compliance and performance
Other
2.81k stars 887 forks source link

Gossipd BROKEN messages #7587

Open Lagrang3 opened 4 weeks ago

Lagrang3 commented 4 weeks ago

I see a lot of BROKEN messages in the logs coming from gossipd

2024-08-16T10:36:17.180Z DEBUG   lightningd: io_break: gossipd_init_done
2024-08-16T10:36:18.659Z DEBUG   gossipd: ...[190 debug messages suppressed]...
2024-08-16T10:36:18.659Z DEBUG   gossipd: channel 749910x1167x1 closing soon due to the funding outpoint being spent
2024-08-16T10:36:18.659Z **BROKEN** gossipd: gossip_store flag-2048 @634914 for 256 already set!
2024-08-16T10:36:18.659Z **BROKEN** gossipd: gossip_store flag-2048 @37138664 for 258 already set!
2024-08-16T10:36:18.659Z **BROKEN** gossipd: gossip_store flag-2048 @27305652 for 258 already set!
2024-08-16T10:36:18.659Z DEBUG   gossipd: channel 850775x1784x0 closing soon due to the funding outpoint being spent
2024-08-16T10:36:18.659Z **BROKEN** gossipd: gossip_store flag-2048 @16036631 for 256 already set!
2024-08-16T10:36:18.659Z **BROKEN** gossipd: gossip_store flag-2048 @35856959 for 258 already set!
2024-08-16T10:36:18.659Z **BROKEN** gossipd: gossip_store flag-2048 @36053676 for 258 already set!

running 52f9678 (v24.08rc2)

Lagrang3 commented 4 weeks ago

I deleted the gossip_store file and now syncing ... There are no more BROKEN messages.

endothermicdev commented 3 weeks ago

Any chance you had rescan set in your config when this occurred?

ShahanaFarooqui commented 3 weeks ago

Closing the issue as it self-resolved.

vincenzopalazzo commented 3 weeks ago

Closing the issue as it self-resolved.

deleted the gossip_store should not be a self-resolution IMHO, except if @Lagrang3 was not running a version pre v24.05 where some of gossipd was buggy!

Lagrang3 commented 3 weeks ago

I was running v24.05 before upgrading, I have no rescan in my config.

cln listconfigs | jq .configs.rescan
{
  "value_int": 15,
  "source": "default"
}
vincenzopalazzo commented 3 weeks ago

I was running v24.05 before upgrading, I have no rescan in my config.

Ok, so this is a bug IMHO catch by @Lagrang3 while running a RC version. We do not have any proof that another user when upgrading from 24.05 will not fall into this bug, but solving it after the release is too late IMHO

openoms commented 22 hours ago

Seen this again on on v24.08 despite I have deleted the gossip store recently for another error. Deleting it again made this message disappear.