search

ElementsProject / lightning

Core Lightning — Lightning Network implementation focusing on spec compliance and performance
Other
2.81k stars 889 forks source link

script: Updating SHASUMS for updated zlib1g-dev in Ubuntu Noble #7612

Closed ShahanaFarooqui closed 3 weeks ago

ShahanaFarooqui commented 3 weeks ago

⚠️ IMPORTANT:

Feature freeze date for v24.08 is Aug 5th.

RC1 is scheduled on Aug 10th, RC2 on Aug 15, ...

The final release is on Aug 22nd.

Issue:

Since we added support for Ubuntu 24.04, it was installing zlib1g-dev version 1:1.3.dfsg-3.1ubuntu2. However zlib released a minor version 1:1.3.dfsg-3.1ubuntu2.1 on Aug 9th.

zlib (1:1.3.dfsg-3.1ubuntu2.1) noble-proposed; urgency=medium

  * SRU: LP: #2076340: No-change rebuild to pick up changed build flags
    on ppc64 and s390x.

Which changed SHASUMS for our noble repro-build.sh and broke the build-release process.

Solution:

1: Either we can update the script with the latest zlib1g-dev SHASUMS Or 2: Lock the zlib1g-dev version to 1:1.3.dfsg-3.1ubuntu2.

For now, I am updating the SHASUMS & version but we can re-consider locking it if the issue keeps repeating in future CLN releases (due to frequent zlib minor version updates).

Changelog-Fixed: core lightning's reproducible build for Ubuntu v24.04 (noble).

niftynei commented 3 weeks ago

ACK 7193f0aa8a1a028d4bcf12b7881f2594d93f952a

endothermicdev commented 3 weeks ago

Had to build with the --no-cache option after this change, i.e., sudo docker build --no-cache -t cl-repro-noble - < contrib/reprobuild/Dockerfile.noble even though I had deleted the previous docker image, but no problems otherwise. ACK 7193f0aa8a1a028d4bcf12b7881f2594d93f952a