s373nZ commented 1 week ago

Repro nightly builds

Description

This pull request attempts to address #7117 to implement Github Actions CI/CD to perform nightly reproducible builds. The goal is to catch local file changes that might emerge through the build process and result in a -modded release version. Currently supporting focal, jammy and noble Ubuntu releases.

Have been testing by adding the following to the on key of .github/workflows/repro.yml:

  push:
    branches:
      - 7117-repro-nightly-builds

Add adding some temporary commit to dirty the tree in the contrib/reprobuild/Dockerfile.[release]

Related Issues

Closes #7117 and hopes to score the bounty :)

Checklist

Ensure the following tasks are completed before submitting the PR:

[x] Changelog has been added in relevant commits.
[x] Tests have been added or updated to cover the changes.
[x] Documentation has been updated as needed.
[x] Any relevant comments or TODOs have been addressed or removed.

Additional Notes

Added an entry to the CHANGELOG -- it was the first one observed since the last release, so also added the front matter.
I started this work a few days ago, without realizing there was a "expiration" date on the Sphinx bounty entry for Aug. 2, 2024. Just before submitting this PR, and rebasing against master, I've noticed @ShahanaFarooqui has made a few commits regarding the repro build process. Don't mean to be stepping on toes! I don't know if this work overlaps, and I'm hoping it still qualifies for the bounty, but if not, please consider it as an alternative submission to whatever planning around repro builds made since Aug. 2.

s373nZ commented 1 week ago

The build failures appear to be in different place each time, and should not be related to my changes, so I assume they are inherited in CI build failures bubbling up from new changes to master over the weekend. I'll do my best to monitor the CI and rebase opportunely. Otherwise, please advise.

s373nZ commented 1 week ago

Some reformatting of the commands and minor syntactical optimizations.

s373nZ commented 3 days ago

Removed modifications to the CHANGELOG.md and opted for a Changelog-None hint in the commit message. Users probably don't care about all the CI processes...

ElementsProject / lightning