Closed laanwj closed 1 week ago
Looks like the grpc mapping needs an analogous change.
These are auto-generated files you edited. The correct fix would be to fix the json schemas. I gave both waitinvoice
and waitanyinvoice
a quick look and they both require a description
in the response. This was fine for bolt11 since invoice
required a description
. offer
does not require a description
so waitinvoice
and waitanyinvoice
schemas should remove description
from it's required section.
Ok, thanks, closing.
cln-rpc: Make
description
field ofWait(any)invoiceResponse
optional stringDescription
In case of a bolt12 invoice, the description field is missing in
waitinvoice
andwaitanyinvoice
responses. Make it optional in the rust struct.Related Issues
N/A afaik
Changes Made
description
field ofWaitanyinvoiceResponse
an optional string.Checklist
Ensure the following tasks are completed before submitting the PR:
TODOs
have been addressed or removed.Review note
Might want to be sure that this is the only response where this is needed? It looks like most invoice response structs have optional description, but not all:
CreateinvoiceResponse
SendinvoiceResponse
I don't think these have a possible BOLT12 path but not sure.
Also this is API breaking-I don't know how versioning is handled in the crate.