Open ErikDeSmedt opened 1 month ago
The test_grpc_connect_notification
failed in the clang compilation target.
I tried to reproduce the failure locally. To do this I compiled Core Lightning using clang.
CC=clang ./configure
Subsequently, I ran the test a 100 times.
for i={1..100}; do PYTEST_OPTS='-k test_cln_grpc_connect_notification' make pytest; done
I haven't observed a single failure. I'm not convinced the test is actually broken and don't have a way to reproduce
This needs a rebase, now that the grpc-host config option has been included.
@ShahanaFarooqui ?
This needs a rebase, since the grpc-host option is now merged (separately).
This needs a rebase, since the grpc-host option is now merged (separately).
I did rebase it on grpc-host option but need to rebase again after 7807 merge. I also need to clean up some commits. Working on them right now.
Pull Request Title
Description
I've added a few configuration options to the gRPC-plugin.
grpc-ip-address
: I've changed the default ip-address to which the gRPC interface will bind from0.0.0.0
to127.0.0.1
. This new default should be more secure. Users who need to access the gRPC-interface externally can setgrpc-ip-address
to the port they like. Users can also configure an IPv6 address.grpc-scheme
: Previously, the gRPC connection only allowed https over mTLS. Configurting mTLS is somewhat cumbersome. Users that only need the gRPC interface locally can now setgrpc-scheme=http
. This will only work ifgrpc-ip-address
is set to a loopback address (127.0.0.1 or equivalent for IPv6).Related Issues
Changes Made
Checklist
Ensure the following tasks are completed before submitting the PR:
TODOs
have been addressed or removed.Additional Notes
Any additional information or context about this PR that reviewers should know.