ElementsProject / lightning

Core Lightning — Lightning Network implementation focusing on spec compliance and performance
Other
2.86k stars 905 forks source link

Add extra configuration options to gRPC #7672

Open ErikDeSmedt opened 1 month ago

ErikDeSmedt commented 1 month ago

Pull Request Title

Description

I've added a few configuration options to the gRPC-plugin.

Related Issues

Changes Made

Checklist

Ensure the following tasks are completed before submitting the PR:

Additional Notes

Any additional information or context about this PR that reviewers should know.

ErikDeSmedt commented 1 month ago

The test_grpc_connect_notification failed in the clang compilation target.

I tried to reproduce the failure locally. To do this I compiled Core Lightning using clang.

CC=clang ./configure

Subsequently, I ran the test a 100 times.

for i={1..100}; do PYTEST_OPTS='-k test_cln_grpc_connect_notification' make pytest; done

I haven't observed a single failure. I'm not convinced the test is actually broken and don't have a way to reproduce

rustyrussell commented 8 hours ago

This needs a rebase, now that the grpc-host config option has been included.

@ShahanaFarooqui ?

rustyrussell commented 4 hours ago

This needs a rebase, since the grpc-host option is now merged (separately).

ShahanaFarooqui commented 4 hours ago

This needs a rebase, since the grpc-host option is now merged (separately).

I did rebase it on grpc-host option but need to rebase again after 7807 merge. I also need to clean up some commits. Working on them right now.