Closed RCasatta closed 2 years ago
I've got a test failure which I am not sure how to tackle (to check the CI the test is temporarily ignored):
---- confidential::tests::nonce_serde stdout ----
thread 'confidential::tests::nonce_serde' panicked at 'expected Token::Bytes([2, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]) but serialized as Tuple { len: 33, }', /home/casatta/.cargo/registry/src/github.com-1ecc6299db9ec823/serde_test-1.0.136/src/ser.rs:240:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Rebased over master, I still have to figure out https://github.com/ElementsProject/rust-elements/pull/147#issuecomment-1259561107
The serde error is due to https://github.com/rust-bitcoin/rust-secp256k1/pull/406
So I think it's expected and I have update the test vector and mentioned in the CHANGELOG
Can you add a commit which renames serde-feature
to serde
similar to how rust-bitcoin does it now? (Will also need a CHANGELOG entry)
Do not merge yet, I've got issues in downstream lib on serde that wasn't there before the rename (suggestion appreciated, not sure what's happening)
Is there a serde
feature on secp256k1-zkp that we need to enable?
Maybe your downstream crate is using a different version of secp-zkp now, and use-serde
isn't enabled on the downstream version.
BTW we missed an opportunity to rename secp-zkp/use-serde
to secp-zkp/serde
when we did the release last week :/
yeah sorry, there is no issue I was just missing a cargo update
( suggested by @noib3 ) so it's mergeable to me, I am going to merge it tomorrow unless @sanket1729 has some feedback
BTW we missed an opportunity to rename secp-zkp/use-serde to secp-zkp/serde when we did the release last week :/
yes, we should have done that, opening an issue -> https://github.com/ElementsProject/rust-secp256k1-zkp/issues/61
bitcoin_hases: bump 0.10.1 -> 0.11.0 rand: bump 0.6.5 -> 0.8
Code changes relate to: