search

ElenaiDev / Feathers

Adds a Stamina System to Minecraft
GNU General Public License v3.0
2 stars 11 forks source link

Log Spam with Unable to Calculate Weight of Non-Armor Item #20

Closed bruglet closed 1 year ago

bruglet commented 1 year ago

Whenever a non-armor item is worn like the Engineer's Goggles from Create it spams the logs with

[Server thread/WARN] [feathers/]: Attempted to calculate weight of non armor item: item.create.goggles

There is no way to stop this behavior and even when a manual override of 0 or 1 is set for the item it still spams the logs.

ElenaiDev commented 1 year ago

Thank you for pointing this out! I am fixing this now, sorry for the inconvenience :)

bruglet commented 1 year ago

Thanks! Would this end up going to 1.19.4/1.20 or 1.19.2? (My modpack is stuck in 1.19.2 so it would be nice if it updated that version too)

Thank you for making such a good mod, I was worried it would be abandoned in the 1.16 era, glad to see it's back. Best dodge mod in Minecraft in my opinion, keep up the good work for the modded community :)

ElenaiDev commented 1 year ago

That's so kind of you to say! I will be releasing it on all versions including 1.19.2 very soon (don't worry!), sorry for the wait; I'm compiling together a collection of patches for other mods, this fix will be uploaded soon.

Thank you very much :)

snowinmars commented 9 months ago

Still on 1.20.1 + forge 47.1.47 + feathers 1.1

image

Can you reopen the issue, please?

bruglet commented 8 months ago

@ElenaiDev It's been a while, but I wanted to let you know that your commit 8d954e6 never made it through to any branch and thus this issue was never fixed! I'll submit a pull request right now to implement the change :)