search

ElenaiDev / Feathers

Adds a Stamina System to Minecraft
GNU General Public License v3.0
2 stars 8 forks source link

1.20.1, ver. 1.1 log spam on equipping skulls #37

Open Jackiecrazy opened 8 months ago

Jackiecrazy commented 8 months ago

https://github.com/ElenaiDev/Feathers/blob/8b0306af18000eedbf24af7c6f3348f9646cef94/src/main/java/com/elenai/feathers/api/FeathersHelper.java#L267 Issue #20 re-manifests as skulls (and engineer's goggles, probably) are not armor items. Also, why does the armor weight config take unlocalized names instead of registry names? Reading the registries into items may improve lookup time. Should I PR something in?

SmokePuddingEveryday commented 5 months ago

Experiencing this in the latest 1.20.1 version with Elytras

bruglet commented 3 months ago

https://github.com/ElenaiDev/Feathers/blob/8b0306af18000eedbf24af7c6f3348f9646cef94/src/main/java/com/elenai/feathers/api/FeathersHelper.java#L267

Issue #20 re-manifests as skulls (and engineer's goggles, probably) are not armor items. Also, why does the armor weight config take unlocalized names instead of registry names? Reading the registries into items may improve lookup time. Should I PR something in?

Experiencing this in the latest 1.20.1 version with Elytras

Should be fixed with the PR, this issue in #20 never made it in the final product and the commit ended up not assigned to any branch.