Elephant418 / Markdownify

The HTML to Markdown converter for PHP
MIT License
192 stars 41 forks source link

Another UL instance #7

Closed spiffyjr closed 9 years ago

spiffyjr commented 10 years ago

Yet another UL conversion that's not handled properly. Works fine on my branch @ https://github.com/spiffyjr/markdownify/tree/feature/ul-fix but not your latest 2.x release.

<div class="content"><strong><span style="text-decoration: underline;">Version 1.1.5c</span></strong><br>
<ul><li>We've added some new cosmetic microtransactions: Vampiric Body Armour Skin, Vampiric Helmet Skin, Vampiric Boots Skin and Vampiric Gloves Skin, Badge of Anguish Shield Skin and Badge of Mirth Shield Skin. There's also a bundle that contains all four Vampiric skins.</li><li>We have prevented league and map mods from being displayed in towns. This is to prevent confusion in leagues that change mods over time while old towns are still open.</li><li>Fixed a bug where minions dominated by Dominating Blow did not have their spells echoed by the Spell Echo support.</li><li>Fixed a bug where the 40% quality total recipe was treated as higher priority than the single 20% quality item recipe.</li><li>Fixed a bug where occasionally Fairgraves, Neverdying never dies.</li><li>Fixed a bug where Dominating Blow minions persisted past the character's death when the player opted to return to a checkpoint.</li><li>Fixed a bug with the interaction of the death of Shield Crabs and the Pyre unique ring.</li></ul></div>
tzi commented 10 years ago

Hi @spiffyjr!

Thanks again for your tests. I understand that your branch is better suited to your needs, but it breaks the nested lists. I made a fix for this case on master & v2.x branch.

Cheers, Thomas.

spiffyjr commented 10 years ago

Right, I just fallback to it when I find a bug. Will test your v2.x branch.

tzi commented 10 years ago

HI @spiffyjr!

Did you tried the fix I wrote?

Have a good day, Thomas.

spiffyjr commented 10 years ago

I haven't had time to yet.

tzi commented 10 years ago

No worries! Thanks again for your help.

tzi commented 10 years ago

I will close this issue for now.

Thanks,
Thomas.