ElettraSciComp / witmotion_IMU_ros

ROS wrapper for the family of IMU sensor devices manufactured by Witmotion Ltd.
MIT License
27 stars 31 forks source link

Ros2 launch #25

Closed JosefGst closed 1 year ago

JosefGst commented 1 year ago

Im using the wit imu in ros2 humbel and the launch file could only be recognized if I renamed them to end with _launch or .launch

twdragon commented 1 year ago

@fllay can you please test the changes on ROS2 stack? Then I could mention you as a reviewer

fllay commented 1 year ago

I will test it this weekend

On Mon, 8 May 2023 at 20:01 Andrei Vukolov @.***> wrote:

@fllay https://github.com/fllay can you please test the changes on ROS2 stack? Then I could mention you as a reviewer

— Reply to this email directly, view it on GitHub https://github.com/ElettraSciComp/witmotion_IMU_ros/pull/25#issuecomment-1538321063, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6HLGYOUKHHNOQSMIBZJ6DXFDVCZANCNFSM6AAAAAAXZNU2JA . You are receiving this because you were mentioned.Message ID: @.***>

twdragon commented 1 year ago

I will test it this weekend On Mon, 8 May 2023 at 20:01 Andrei Vukolov @.> wrote: @fllay https://github.com/fllay can you please test the changes on ROS2 stack? Then I could mention you as a reviewer — Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6HLGYOUKHHNOQSMIBZJ6DXFDVCZANCNFSM6AAAAAAXZNU2JA . You are receiving this because you were mentioned.Message ID: @.>

@fllay thank you! Looking forward to seeing the test report from you!

fllay commented 1 year ago

I tested with WT61C. It seems to be OK.

twdragon commented 1 year ago

@fllay thanks, so I consider this PR to merge.