Open isdanni opened 6 months ago
Please ignore the previous comments. Using pip install -e .
solved the package issue.
pytest
on a single-core machine, there are 5 failed tests related to not having more than 1 GPU. If the elk package can only run in a multi-core environment, please specify it in the documentation. @isdanni thanks for the review! I'll update the things and let you know once it that's done
@isdanni I've done the changes and merged the latest main into the joss-paper branch. The pull-request will merged soon: https://github.com/EleutherAI/ccs/pull/9
@isdanni I've done the changes and merged the latest main into the joss-paper branch. The pull-request will merged soon: #9
Thanks for the update! I checked off most of the task items. Just one last thing(very minor issue):
In the Introduction section of README.md, the bold syntax does not work with URL; Unless this is intended I'd suggest removing it for better readability.
@isdanni thanks: https://github.com/EleutherAI/ccs/pull/10/files :)
Thanks for submitting to JOSS! Note: this is a review thread, more checklist items will be added.
tracking review progress: https://github.com/openjournals/joss-reviews/issues/6511
Documentation
Minor issues