add requirements and update readme

EleutherAI / sae

Sparse autoencoders

MIT License

333 stars 46 forks source link

add requirements and update readme #6

Closed Lewington-pitsos closed 3 months ago

Lewington-pitsos commented 4 months ago

I can confirm that after installing the requirements.txt the example code from the readme runs without issue on Ubuntu 22.04.

this repo is really cool, I'm just testing it out at the moment but there's anything else that I can help with please let me know.

CLAassistant commented 4 months ago

All committers have signed the CLA.

norabelrose commented 4 months ago

Hmm I'd prefer not to duplicate the list of requirements, since they are already included in the pyproject.toml. I'll update the README to make it clear that you can pip install the library once you've cloned it to get the required libraries.

And I plan to get rid of the hard Triton dependency today

AmanPriyanshu commented 3 months ago

Had a query regarding triton dependency as well and whether it would be removed in the future

AmanPriyanshu commented 3 months ago

Was able to install triton in Mac through the following steps - for reference till dependency is removed:

git clone git@github.com:triton-lang/triton.git;
cd triton/python;
pip install ninja cmake wheel;
pip install .

Allowed installation of sae

norabelrose commented 3 months ago

Was able to install triton in Mac through the following steps - for reference till dependency is removed:
git clone git@github.com:triton-lang/triton.git;
cd triton/python;
pip install ninja cmake wheel;
pip install .
Allowed installation of sae

Oh cool. For now you can at least use other parts of sae without triton since I moved the import statement inside decode itself. I'll close this PR once we have full out-of-the-box Mac support.

norabelrose commented 3 months ago

Triton dependency removed in fdde64c