Elevate-Lab / elevate-lab-website

A website to inform and invite contributors to elevate-lab

https://elevate-lab.github.io/elevate-lab-website/

MIT License

18 stars 64 forks source link

Fixed Bg-Color Property for Navbar Items #135

Closed uglyprincess closed 4 years ago

uglyprincess commented 4 years ago

Pull Request

Proposed Changes

I edited the styles.css file so that upon clicking the inactive navbar items, their background color does not change.
Fixes #134 .

Types of changes made

[x] Fixed Bug
[ ] Added new Features
[x] Edited Documentations
[x] Enhanced the working of code
[ ] Additional Changes

Additional Info

I added the following code to styles.css in order to fix this issue: a.item-nav:focus { background-color: #0A192F; }

Viability of Code

Describe the tests that you ran to verify the changes made. Mention the tests for easy reproducibility.

Clicked on the navbar-items repeatedly without encountering any problems.

Mention(if any) specific Test Configurations used:

Screenshots or GIFs (if any)

Attach screenshots of the changes made for easy reference. Original	Updated

|

Checklist:

[x] My code follows the Mentioned Guidelines for the project
[x] I have self-reviewed the changes made
[] I have made the changes easy to understand by adding comments
[x] My changes does not generate new warnings/errors
[x] I have attached relevant screenshots to display the changes made
[x] I have made the required changes to the documentations

2802harsh commented 4 years ago

@Tlazypanda ma'am pls review and merge this PR.

2802harsh commented 4 years ago

The changes look all good! And it solves the issue. @Tlazypanda ma'am pls merge this PR