Elevate-Lab / elevate-lab-website

A website to inform and invite contributors to elevate-lab
https://elevate-lab.github.io/elevate-lab-website/
MIT License
18 stars 64 forks source link

Issue 117 fetch project card data from json #137

Closed Thilagavathi1 closed 4 years ago

Thilagavathi1 commented 4 years ago

Pull Request

Proposed Changes

Types of changes made

welcome[bot] commented 4 years ago

Hello there!๐Ÿ‘‹ Elevate-Lab heartly๐Ÿ˜ƒ welcomes you to the project!๐Ÿ’– Thank you and congrats๐ŸŽ‰ for opening your first pull request.โœจ.We will get back to you as soon as we can.๐Ÿ˜„

Thilagavathi1 commented 4 years ago

@garvitchittora @Tlazypanda Please check this PR and merge it.

garvitchittora commented 4 years ago

@Thilagavathi1 please resolve the conflict and we want 3 project cards in one row right, so this will not work for your code means all cards will be visible in one row only in place of 3 cards in each row as per your code (for reference please check team.js).

Thilagavathi1 commented 4 years ago

ProjectsPage @garvitchittora Resolved the merge conflicts.please check the screenshots for the projects page.

garvitchittora commented 4 years ago

@Thilagavathi1 we want 3 project cards in one row right, so this will not work for your code means all cards will be visible in one row only in place of 3 cards in each row as per your code (for reference please check team.js).

I think you have not resolved the row issue, plz solve that part.

Thilagavathi1 commented 4 years ago

@Thilagavathi1 we want 3 project cards in one row right, so this will not work for your code means all cards will be visible in one row only in place of 3 cards in each row as per your code (for reference please check team.js).

I think you have not resolved the row issue, plz solve that part.

@garvitchittora i have displayed how it was displayed previousely.Please check the screenshots below. ProjectsPage This is how the projects screen is looks like in my branch. whats is your expected design for the projects screen.

garvitchittora commented 4 years ago

Hi @Thilagavathi1, this is your result (I have cloned your repo.), now please see in this ss in one row 4 cards are there but we need 3 in one row.

Screenshot (380)

Thilagavathi1 commented 4 years ago

Hi @Thilagavathi1, this is your result (I have cloned your repo.), now please see in this ss in one row 4 cards are there but we need 3 in one row.

Screenshot (380)

Got it now. let me rework on it

Thilagavathi1 commented 4 years ago

@garvitchittora have made the changes as per your requirements.Please check this and let me know the feedback.if everything works fine. please merge it with "hacktoberfest-accepted" label.

welcome[bot] commented 4 years ago

Congrats on merging your first pull request! ๐ŸŽ‰๐ŸŽ‰๐ŸŽ‰